Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #203

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Housekeeping #203

merged 5 commits into from
Dec 28, 2023

Conversation

JoshuaEstes
Copy link
Member

Description

Checklist

  • Updated CHANGELOG files
  • Updated Documentation
  • Unit Tests Created
  • php-cs-fixer

@github-actions github-actions bot added the bard label Dec 27, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9cd723e) 72.94% compared to head (010dc06) 73.33%.

Files Patch % Lines
.../SonsOfPHP/Bard/src/Console/Command/AddCommand.php 0.00% 1 Missing ⚠️
...SonsOfPHP/Bard/src/Console/Command/CopyCommand.php 0.00% 1 Missing ⚠️
...sOfPHP/Bard/src/Console/Command/ReleaseCommand.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #203      +/-   ##
============================================
+ Coverage     72.94%   73.33%   +0.39%     
  Complexity     1362     1362              
============================================
  Files           208      208              
  Lines          3308     3308              
============================================
+ Hits           2413     2426      +13     
+ Misses          895      882      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaEstes JoshuaEstes marked this pull request as ready for review December 28, 2023 13:45
@JoshuaEstes JoshuaEstes requested a review from a team as a code owner December 28, 2023 13:45
@JoshuaEstes JoshuaEstes added this pull request to the merge queue Dec 28, 2023
Merged via the queue into SonsOfPHP:main with commit 5ad14f5 Dec 28, 2023
4 of 5 checks passed
@JoshuaEstes JoshuaEstes deleted the housekeeping branch December 28, 2023 13:45
JoshuaEstes added a commit to JoshuaEstes/sonsofphp that referenced this pull request Jan 3, 2024
* main:
  Housekeeping (SonsOfPHP#203)
  [EventDispatcher] Adding a few new things and working on docs (SonsOfPHP#202)
  [Bard] various changes and updates (SonsOfPHP#201)
  Adding Churn PHP as a tool in the repo (SonsOfPHP#200)
  Update symfony/phpunit-bridge requirement from ^6 to ^6 || ^7 (SonsOfPHP#192)
  [Mailer] New Component and Contract (SonsOfPHP#190)
  [Mailer] New Component and Contract (SonsOfPHP#189)
  House Keeping (SonsOfPHP#188)
  [HttpHandler] Component (SonsOfPHP#187)
  [Container] New Component (SonsOfPHP#182)
  [Cookie] New Component & Contract (SonsOfPHP#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants