[Cookie] New Component & Contract #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
JoshuaEstes
added a commit
to JoshuaEstes/sonsofphp
that referenced
this pull request
Dec 8, 2023
* main: [Mailer] New Component and Contract (SonsOfPHP#190) [Mailer] New Component and Contract (SonsOfPHP#189) House Keeping (SonsOfPHP#188) [HttpHandler] Component (SonsOfPHP#187) [Container] New Component (SonsOfPHP#182) [Cookie] New Component & Contract (SonsOfPHP#181) [Pager] Doctrine Bridge (SonsOfPHP#175) fuckery (SonsOfPHP#174) [Money] Add Twig Bridge (SonsOfPHP#173) docs
JoshuaEstes
added a commit
to JoshuaEstes/sonsofphp
that referenced
this pull request
Jan 3, 2024
* main: Housekeeping (SonsOfPHP#203) [EventDispatcher] Adding a few new things and working on docs (SonsOfPHP#202) [Bard] various changes and updates (SonsOfPHP#201) Adding Churn PHP as a tool in the repo (SonsOfPHP#200) Update symfony/phpunit-bridge requirement from ^6 to ^6 || ^7 (SonsOfPHP#192) [Mailer] New Component and Contract (SonsOfPHP#190) [Mailer] New Component and Contract (SonsOfPHP#189) House Keeping (SonsOfPHP#188) [HttpHandler] Component (SonsOfPHP#187) [Container] New Component (SonsOfPHP#182) [Cookie] New Component & Contract (SonsOfPHP#181)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #125
The cookie class should not be responsible for sending the headers or pulling name/value from
$_COOKIE. This would be the job of the cookie manager. Cookie manager uses$_COOKIEto grab cookies. If a cookie does not exist, it uses the factory to create one. Sending the Set-Cookie header should be done be the cookie manager as well.The Cookie class should be about to output the header value. Should be able to do something like:
Checklist