Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logger] Finish up Logger Component #123

Merged
merged 6 commits into from
Nov 14, 2023
Merged

[Logger] Finish up Logger Component #123

merged 6 commits into from
Nov 14, 2023

Conversation

JoshuaEstes
Copy link
Member

@JoshuaEstes JoshuaEstes commented Nov 14, 2023 •
edited
Loading

Description

Checklist

  • Updated CHANGELOG files
  • Updated Documentation
  • Unit Tests Created
  • php-cs-fixer

@JoshuaEstes JoshuaEstes changed the title Logger [Logger] Finish up Logger Component Nov 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (f128469) 72.02% compared to head (c9d104c) 72.27%.
Report is 1 commits behind head on main.

Files Patch % Lines
...OfPHP/Component/Logger/Handler/AbstractHandler.php 0.00% 6 Missing ⚠️
...SonsOfPHP/Component/Logger/Handler/FileHandler.php 80.95% 4 Missing ⚠️
...nsOfPHP/Component/Logger/Handler/StreamHandler.php 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #123      +/-   ##
============================================
+ Coverage     72.02%   72.27%   +0.25%     
- Complexity     1118     1128      +10     
============================================
  Files           182      180       -2     
  Lines          2824     2846      +22     
============================================
+ Hits           2034     2057      +23     
+ Misses          790      789       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaEstes JoshuaEstes marked this pull request as ready for review November 14, 2023 02:01
@JoshuaEstes JoshuaEstes requested a review from a team as a code owner November 14, 2023 02:01
@JoshuaEstes JoshuaEstes merged commit e0a6704 into SonsOfPHP:main Nov 14, 2023
4 of 5 checks passed
@JoshuaEstes JoshuaEstes deleted the logger branch November 14, 2023 02:02
JoshuaEstes added a commit to JoshuaEstes/sonsofphp that referenced this pull request Nov 30, 2023
@JoshuaEstes
Merge remote-tracking branch 'upstream/main' into user_agent
c93e9b8 
* upstream/main: (54 commits)
  [Pager] Doctrine Bridge (SonsOfPHP#175)
  fuckery (SonsOfPHP#174)
  [Money] Add Twig Bridge (SonsOfPHP#173)
  docs
  coverage fix
  typo
  SonsOfPHP#63 | Link Component (SonsOfPHP#170)
  Pager Component (SonsOfPHP#134)
  Pager Contract (SonsOfPHP#133)
  Update README.md (SonsOfPHP#124)
  [Logger] Finish up Logger Component (SonsOfPHP#123)
  Makefile
  [Logger] New Component (SonsOfPHP#120)
  bug
  [HttpMessage] Helper Methods on Uri to make it easier to create Uri objects with query params (SonsOfPHP#119)
  bug fixes
  Bug fix
  Making a few changes and breaking shit (SonsOfPHP#118)
  updating a few docs (SonsOfPHP#117)
  typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaEstes @codecov-commenter