Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making a few changes and breaking shit #118

Merged
merged 27 commits into from
Nov 11, 2023

Conversation

JoshuaEstes
Copy link
Member

No description provided.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2023
@JoshuaEstes JoshuaEstes marked this pull request as ready for review November 11, 2023 21:07
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (e645565) 65.85% compared to head (468ec6c) 70.81%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #118      +/-   ##
============================================
+ Coverage     65.85%   70.81%   +4.96%     
- Complexity      886     1022     +136     
============================================
  Files           145      162      +17     
  Lines          2308     2577     +269     
============================================
+ Hits           1520     1825     +305     
+ Misses          788      752      -36     
Files Coverage Δ
.../Command/AbstractOptionsResolverCommandMessage.php 100.00% <ø> (ø)
...SonsOfPHP/Component/Cache/Adapter/ArrayAdapter.php 100.00% <100.00%> (ø)
...SonsOfPHP/Component/Cache/Adapter/ChainAdapter.php 100.00% <100.00%> (ø)
.../SonsOfPHP/Component/Cache/Adapter/NullAdapter.php 100.00% <100.00%> (ø)
src/SonsOfPHP/Component/Cache/CacheItem.php 100.00% <100.00%> (ø)
src/SonsOfPHP/Component/Cache/CacheItemFactory.php 100.00% <100.00%> (ø)
src/SonsOfPHP/Component/Clock/FixedClock.php 100.00% <ø> (ø)
src/SonsOfPHP/Component/Cqrs/AbstractBus.php 100.00% <100.00%> (ø)
src/SonsOfPHP/Component/Cqrs/CommandBus.php 100.00% <100.00%> (ø)
...onsOfPHP/Component/Cqrs/MessageHandlerProvider.php 100.00% <100.00%> (ø)
... and 49 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaEstes JoshuaEstes merged commit 31fea3e into SonsOfPHP:main Nov 11, 2023
4 of 5 checks passed
@JoshuaEstes JoshuaEstes deleted the contracts branch November 11, 2023 21:09
JoshuaEstes added a commit to JoshuaEstes/sonsofphp that referenced this pull request Nov 30, 2023
* upstream/main: (54 commits)
  [Pager] Doctrine Bridge (SonsOfPHP#175)
  fuckery (SonsOfPHP#174)
  [Money] Add Twig Bridge (SonsOfPHP#173)
  docs
  coverage fix
  typo
  SonsOfPHP#63 | Link Component (SonsOfPHP#170)
  Pager Component (SonsOfPHP#134)
  Pager Contract (SonsOfPHP#133)
  Update README.md (SonsOfPHP#124)
  [Logger] Finish up Logger Component (SonsOfPHP#123)
  Makefile
  [Logger] New Component (SonsOfPHP#120)
  bug
  [HttpMessage] Helper Methods on Uri to make it easier to create Uri objects with query params (SonsOfPHP#119)
  bug fixes
  Bug fix
  Making a few changes and breaking shit (SonsOfPHP#118)
  updating a few docs (SonsOfPHP#117)
  typo
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bard documentation Improvements or additions to documentation filesystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants