Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java IT that documents the current de-duplication logic #5423

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Java IT that documents the current de-duplication logic #5423

merged 3 commits into from
Feb 25, 2022

Conversation

csaba-sagi-sonarsource
Copy link
Contributor

Reproduces #5417

costin-zaharia-sonarsource
costin-zaharia-sonarsource reviewed Feb 24, 2022
View reviewed changes
its/projects/ProjectLevelDuplication/ClassLibrary2/ClassLibrary2.csproj Outdated
<Reference Include="System.Core"/>
<Reference Include="System.Xml.Linq"/>
<Reference Include="System.Data.DataSetExtensions"/>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whi all these spaces? Do we even need these references?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely no idea where these empty lines came from :) I removed all the references as they were not needed. Thanks for pointing it out.

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

costin-zaharia-sonarsource
costin-zaharia-sonarsource approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@csaba-sagi-sonarsource csaba-sagi-sonarsource merged commit 1eef25a into master Feb 25, 2022
@csaba-sagi-sonarsource csaba-sagi-sonarsource deleted the čaba/repro-4-projectLevelDuplication branch February 25, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin-zaharia-sonarsource costin-zaharia-sonarsource costin-zaharia-sonarsource approved these changes

Assignees

@csaba-sagi-sonarsource csaba-sagi-sonarsource

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csaba-sagi-sonarsource @costin-zaharia-sonarsource