Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple project level issues #5417

Closed
csaba-sagi-sonarsource opened this issue Feb 21, 2022 · 3 comments · Fixed by #9407
Closed

Enable multiple project level issues #5417

csaba-sagi-sonarsource opened this issue Feb 21, 2022 · 3 comments · Fixed by #9407
Assignees
Labels
Area: SQ Plugin Java plugin related issues.
Milestone

Comments

@csaba-sagi-sonarsource
Copy link
Contributor

Description

Currently if there are more than one project level issues, only the first one will be imported. There is a de-duplication logic in the SarifParserCallbackImpl (See here). This means for example if there are multiple projects with S3904 violations (No AssemblyVersion attribute for the assemly), only one issue will be reported for one assembly.

Repro steps

Add two projects that do not contain an AssemblyVersion attribute.
Analyze the projects with rule S3904 enabled.
And only one issue will appear in SQ/SC.

Expected behavior

All issues are correctly reported.

Actual behavior

Only one issue is reported.

Known workarounds

Related information

  • C#/VB.NET Plugins version: 8.35.0.42613
@martin-strecker-sonarsource
Copy link
Contributor

Does this change also solve flaky issues like this one? (Look in the "Activities" tab)
https://peach.aws-prd.sonarsource.com/project/issues?issues=AXg6jiAvqKPOqfVzH4ae&open=AXg6jiAvqKPOqfVzH4ae&id=screentogif

image

@costin-zaharia-sonarsource
Copy link
Member

I'm not sure (I did not manually test this, and I'm not sure if the order in which the reports are processed is consistent between the runs), but I think it might. With the previous implementation, only one of many raised issues was reported to the server.

@martin-strecker-sonarsource
Copy link
Contributor

martin-strecker-sonarsource commented Jun 10, 2024

It looks like S3990 is new for the "HookTest" assembly, while S4026 was (or still is) flaky.
image

See here https://peach.aws-prd.sonarsource.com/project/issues?resolved=false&id=screentogif&open=AXg6jiAvqKPOqfVzH4ae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SQ Plugin Java plugin related issues.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants