path normalization / absolutization is not allowed to use File::getCanonicalPath() #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simplify * add logs
* org.sonar.api.batch.fs.FileSystem::resolvePath() returns canonical form * rewrite it by means of Path::normalize() * review the sensor code, which performs normalization * minor changes
ivangalkin
changed the title
Path absolutization is never a good idea. Especially in the coverage sensor, which caches the file paths. See SonarOpenCommunity#1465
guwirth
approved these changes
Oct 17, 2018
|
@jmecosta ok for me. Do you have any comments? Think you had some special cases in your CI? |
|
@guwirth i think we have integration tests for bullseye in place, it should be ok by me also. i will raise issue if something goes bad in our instances. i dont expect so |
jmecosta
approved these changes
Oct 23, 2018
|
Hi @guwirth and @ivangalkin . I've recently bumped in this issue in 1.1.0 and seems to be fixed by this PR. Any plans for releasing this? |
|
Hi @ericlemes, will be part of 1.2, see #1579. You are welcome to try it out and give feedback. |
This was referenced Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path normalization / absolutization is not allowed to use
File::getCanonicalPath(). If performed on Linux (Unix), this method resolves the symbolic links. This fact might make the queries like "is this normalized path in SonarQube project" go wrong.Fixed #1574
Fixes #1465
CoberturaParserusedCxxUtils::normalizePathFull()Misc:
CxxUtils::normalizePathFull()This change is