Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

path normalization / absolutization is not allowed to use File::getCanonicalPath() #1575

Merged
merged 4 commits into from
Oct 23, 2018
Merged

path normalization / absolutization is not allowed to use File::getCanonicalPath() #1575

merged 4 commits into from
Oct 23, 2018

Commits on Oct 12, 2018

  1. clean-up file path resolution (see SonarOpenCommunity#1574) 

    * simplify
* add logs
    @ivangalkin
    ivangalkin committed Oct 12, 2018
    Configuration menu
    Copy the full SHA
    cd17e4f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2018

  1. rewrite CxxUtils::normalizePathFull() without symbolic link resolution 

    * org.sonar.api.batch.fs.FileSystem::resolvePath() returns canonical form
* rewrite it by means of Path::normalize()

* review the sensor code, which performs normalization
* minor changes
    @ivangalkin
    ivangalkin committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    f8f599a View commit details
    Browse the repository at this point in the history

  2. remove the helpers CxxUtils::normalizePathFull() completely... 

    Path absolutization is never a good idea. Especially in the coverage
sensor, which caches the file paths.

See SonarOpenCommunity#1465
    @ivangalkin
    ivangalkin committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    e2cf094 View commit details
    Browse the repository at this point in the history

  3. restore debug logging in CxxCoverageSensor

    @ivangalkin
    ivangalkin committed Oct 14, 2018
    Configuration menu
    Copy the full SHA
    f7c06dd View commit details
    Browse the repository at this point in the history