Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SensorDescriptors for CxxCompiler{Gcc|Vc}Sensor #1534

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fix SensorDescriptors for CxxCompiler{Gcc|Vc}Sensor #1534

merged 1 commit into from
Aug 9, 2018

Conversation

ivangalkin
Copy link
Contributor

@ivangalkin ivangalkin commented Aug 7, 2018 •
edited by SonarOpenCommunityAdmin
Loading

@ivangalkin
Copy link
Contributor Author

Hi @guwirth, here is the discussed fix. Unfortunately it introduces a conflict with #1533 (especially in CxxCompilerSensorTest.java). I hope it's ok. Regards.

@ivangalkin ivangalkin requested a review from guwirth August 7, 2018 21:31
@guwirth guwirth added the bug label Aug 8, 2018
@guwirth guwirth added this to the 1.2 milestone Aug 8, 2018
@guwirth guwirth merged commit f72c496 into SonarOpenCommunity:master Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guwirth guwirth guwirth approved these changes

Assignees

@ivangalkin ivangalkin

Labels
bug
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ivangalkin @guwirth