Split compiler sensor into GCC and MSVC compiler to use it at the same time #1533

guwirth · 2018-08-05T12:19:16Z

Users like to use the VC and GCC compiler results in parallel.

refactoring of compiler sensors
close Refactoring: Split compiler sensor into GCC and MSVC compiler to use it at the same time #1180

Attention:

This is a breaking change - sonar.cxx.compiler settings are no more supported.
you have to define the named groups <file>, <line>, <id>, <message> in your regex now:
(.*>)?(?<file>.*)$(?<line>\d+)$\x20:\x20warning\x20(?<id>C\d+):(?<message>.*)
Reading messages line by line: ^...$ no more needed in the regex
tbd: update wiki after merge

Remove:

sonar.cxx.compiler.parser
sonar.cxx.compiler.reportPath
sonar.cxx.compiler.regex
sonar.cxx.compiler.charset

Add:

sonar.cxx.vc.reportPath
sonar.cxx.vc.regex
sonar.cxx.vc.charset

sonar.cxx.gcc.reportPath
sonar.cxx.gcc.regex
sonar.cxx.gcc.charset

To read includes and defines from MSBuild log use:

sonar.cxx.msbuild.reportPath
sonar.cxx.msbuild.charset

This change is

guwirth · 2018-08-06T05:32:53Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccParser.java

+      MatchResult matchres;
+      while (scanner.findWithinHorizon(p, 0) != null) {
+        matchres = scanner.match();
+        String filename = matchres.group(1).trim();


In case group not available could be null

Since findWithinHorizon() is used as pre-requirement for match(), the MatchResult contains the proper results. Maybe we could assert the number of groups at runtime (matchres.groupCount() >=5). However it's sufficient to double-check the corresponding expression IMHO

guwirth · 2018-08-06T05:33:40Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccSensor.java

+  public static final String REPORT_PATH_KEY = "gcc.reportPath";
+  public static final String REPORT_REGEX_DEF = "gcc.regex";
+  public static final String REPORT_CHARSET_DEF = "gcc.charset";
+  public static final String DEFAULT_CHARSET_DEF = "UTF-8";


What is default charset for GCC?

IMHO UTF-8 is de-facto standard for all OSs and can be used as default charset for each input file.

guwirth · 2018-08-06T05:34:00Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccSensor.java

+  public static final String REPORT_CHARSET_DEF = "gcc.charset";
+  public static final String DEFAULT_CHARSET_DEF = "UTF-8";
+  // search for single line with compiler warning message - order for groups: 1=file, 2=line, 3=message, 4=id
+  public static final String DEFAULT_REGEX_DEF = "^(.*):([0-9]+):[0-9]+:\\x20warning:\\x20(.*)\\x20\\[(.*)\\]$";


Is this latest regex for GCC?

guwirth · 2018-08-06T05:35:28Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/vc/CxxCompilerVcParser.java

@@ -96,7 +67,7 @@ public void processReport(final SensorContext context, File report, String chars

  private static String removeMPPrefix(String fpath) {


Do we really need this MP prefix removal as an extra step? Could be part of global regex?

guwirth · 2018-08-06T05:36:36Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/vc/CxxCompilerVcSensor.java

+  public static final String REPORT_PATH_KEY = "vc.reportPath";
+  public static final String REPORT_REGEX_DEF = "vc.regex";
+  public static final String REPORT_CHARSET_DEF = "vc.charset";
+  public static final String DEFAULT_CHARSET_DEF = "UTF-8"; // use "UTF-16" for VS2010 build log or TFS Team build log file


What is the latest charset for VS2017?

guwirth · 2018-08-06T05:36:58Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/vc/CxxCompilerVcSensor.java

+  public static final String REPORT_CHARSET_DEF = "vc.charset";
+  public static final String DEFAULT_CHARSET_DEF = "UTF-8"; // use "UTF-16" for VS2010 build log or TFS Team build log file
+  // search for single line with compiler warning message VS2008 - order for groups: 1=file, 2=line, 3=ID, 4=message
+  public static final String DEFAULT_REGEX_DEF = "^(.*)\\((\\d+)\\)\\x20:\\x20warning\\x20(C\\d+):(.*)$";


What is the regex for VS2017?

guwirth · 2018-08-06T05:38:53Z

cxx-squid/src/main/java/org/sonar/cxx/CxxMetricsFactory.java

@@ -52,7 +52,8 @@ private CxxMetricsFactory() {
    // Introduce metric keys for sensors - number of issues per file / per module
    CLANG_SA_SENSOR_ISSUES_KEY("ClangSA"),
    CLANG_TIDY_SENSOR_ISSUES_KEY("Clang-Tidy"),
-    COMPILER_SENSOR_ISSUES_KEY("Compiler"),
+    VC_SENSOR_ISSUES_KEY("Compiler-VC"),


Which metric keys should we use?
Compiler-XXX, or only XXX?

Compiler-XXX look more consistent to me

guwirth · 2018-08-06T05:39:44Z

cxx-squid/src/main/java/org/sonar/cxx/CxxMetricsFactory.java

@@ -104,7 +105,8 @@ public String toString() {

    addSensorMetric(Key.CLANG_SA_SENSOR_ISSUES_KEY, "ClangSA issues", domain, langPropertiesKey, metrics);
    addSensorMetric(Key.CLANG_TIDY_SENSOR_ISSUES_KEY, "ClangTidy issues", domain, langPropertiesKey, metrics);
-    addSensorMetric(Key.COMPILER_SENSOR_ISSUES_KEY, "Compiler issues", domain, langPropertiesKey, metrics);
+    addSensorMetric(Key.VC_SENSOR_ISSUES_KEY, "VC compiler issues", domain, langPropertiesKey, metrics);


Same here?
VC compiler issues
-or- only
VC issues

VC compiler issues IMHO

ivangalkin

@guwirth the following diff is mandatory. Should I push it as a small fix right-away? or will you include it in your PR? In any way the bug should be fixed before the next release. Thank you.

diff --git a/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerGccSensor.java b/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerGccSensor.java
index 8315dca..dfbbf0c 100644
--- a/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerGccSensor.java
+++ b/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerGccSensor.java
@@ -47,6 +47,6 @@ public class CxxCompilerGccSensor extends CxxCompilerSensor {
   @Override
   public void describe(SensorDescriptor descriptor) {
     descriptor.name(getLanguage().getName() + " CxxCompilerGccSensor").onlyOnLanguage(getLanguage().getKey())
-        .createIssuesForRuleRepositories(getReportPathKey()).onlyWhenConfiguration(new IsGccParserConfigured());
+        .createIssuesForRuleRepository(getRuleRepositoryKey()).onlyWhenConfiguration(new IsGccParserConfigured());
   }
 }
diff --git a/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerVcSensor.java b/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerVcSensor.java
index a5ff161..df88ce4 100644
--- a/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerVcSensor.java
+++ b/cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerVcSensor.java
@@ -50,6 +50,6 @@ public class CxxCompilerVcSensor extends CxxCompilerSensor {
   @Override
   public void describe(SensorDescriptor descriptor) {
     descriptor.name(getLanguage().getName() + " CxxCompilerVcSensor").onlyOnLanguage(getLanguage().getKey())
-        .createIssuesForRuleRepositories(getReportPathKey()).onlyWhenConfiguration(new IsVcParserConfigured());
+        .createIssuesForRuleRepository(getRuleRepositoryKey()).onlyWhenConfiguration(new IsVcParserConfigured());
   }
 }

ivangalkin · 2018-08-06T22:50:09Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerSensor.java

    try {
      parser.processReport(context, report, reportCharset, reportRegEx, warnings);
      for (CompilerParser.Warning w : warnings) {
        if (isInputValid(w)) {
          CxxReportIssue issue = new CxxReportIssue(w.id, w.filename, w.line, w.msg);
          saveUniqueViolation(context, issue);
        } else {
-          LOG.warn("C-Compiler warning: '{}''{}'", w.id, w.msg);
+          LOG.warn("Invalid compiler warning: '{}''{}'", w.id, w.msg);


Unrecognized compiler warning?

ivangalkin · 2018-08-06T23:00:44Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccParser.java

+      MatchResult matchres;
+      while (scanner.findWithinHorizon(p, 0) != null) {
+        matchres = scanner.match();
+        String filename = matchres.group(1).trim();


Since findWithinHorizon() is used as pre-requirement for match(), the MatchResult contains the proper results. Maybe we could assert the number of groups at runtime (matchres.groupCount() >=5). However it's sufficient to double-check the corresponding expression IMHO

ivangalkin · 2018-08-06T23:01:29Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccParser.java

+    try (Scanner scanner = new Scanner(report, charset)) {
+      Pattern p = Pattern.compile(reportRegEx, Pattern.MULTILINE);
+      LOG.debug("Using pattern : '{}'", p);
+      MatchResult matchres;


I would move MatchResult matchres into the loop

ivangalkin · 2018-08-06T23:02:54Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccSensor.java

+  public static final String REPORT_PATH_KEY = "gcc.reportPath";
+  public static final String REPORT_REGEX_DEF = "gcc.regex";
+  public static final String REPORT_CHARSET_DEF = "gcc.charset";
+  public static final String DEFAULT_CHARSET_DEF = "UTF-8";


IMHO UTF-8 is de-facto standard for all OSs and can be used as default charset for each input file.

ivangalkin · 2018-08-06T23:07:47Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccSensor.java

+  public static final String DEFAULT_CHARSET_DEF = "UTF-8";
+  // search for single line with compiler warning message - order for groups: 1=file, 2=line, 3=message, 4=id
+  public static final String DEFAULT_REGEX_DEF = "^(.*):([0-9]+):[0-9]+:\\x20warning:\\x20(.*)\\x20\\[(.*)\\]$";
+  // ToDo: as long as java 7 API is not used the support of named groups for regular expression is not possible


currently we use java8 and named regexp groups are supported since java7
so we can rewrite the comment as // TODO use named groups

ivangalkin · 2018-08-06T23:09:59Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccSensor.java

+    descriptor
+      .name(getLanguage().getName() + " CxxCompilerGccSensor")
+      .onlyOnLanguage(getLanguage().getKey())
+      .createIssuesForRuleRepositories(getReportPathKey())


ERROR: please use getRuleRepositoryKey() (embarrassingly I've introduced it by myself)

ivangalkin · 2018-08-06T23:16:00Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/vc/CxxCompilerVcSensor.java

+    descriptor
+      .name(getLanguage().getName() + " CxxCompilerVcSensor")
+      .onlyOnLanguage(getLanguage().getKey())
+      .createIssuesForRuleRepositories(getReportPathKey())


ERROR: getReportPathKey() -> getRuleRepositoryKey()

ivangalkin · 2018-08-06T23:18:44Z

cxx-sensors/src/test/java/org/sonar/cxx/sensors/compiler/gcc/CxxCompilerGccSensorTest.java

+import org.sonar.cxx.sensors.compiler.CxxCompilerSensor;
+import org.sonar.cxx.sensors.utils.TestUtils;
+
+public class CxxCompilerGccSensorTest {


since we already have an issue in Sensor::describe() method, I would suggest to add

@Test public void sensorDescriptor() { ... }

both for GCC and VC sensors

ivangalkin · 2018-08-06T23:19:35Z

cxx-squid/src/main/java/org/sonar/cxx/CxxMetricsFactory.java

@@ -52,7 +52,8 @@ private CxxMetricsFactory() {
    // Introduce metric keys for sensors - number of issues per file / per module
    CLANG_SA_SENSOR_ISSUES_KEY("ClangSA"),
    CLANG_TIDY_SENSOR_ISSUES_KEY("Clang-Tidy"),
-    COMPILER_SENSOR_ISSUES_KEY("Compiler"),
+    VC_SENSOR_ISSUES_KEY("Compiler-VC"),


Compiler-XXX look more consistent to me

ivangalkin · 2018-08-06T23:20:15Z

cxx-squid/src/main/java/org/sonar/cxx/CxxMetricsFactory.java

@@ -104,7 +105,8 @@ public String toString() {

    addSensorMetric(Key.CLANG_SA_SENSOR_ISSUES_KEY, "ClangSA issues", domain, langPropertiesKey, metrics);
    addSensorMetric(Key.CLANG_TIDY_SENSOR_ISSUES_KEY, "ClangTidy issues", domain, langPropertiesKey, metrics);
-    addSensorMetric(Key.COMPILER_SENSOR_ISSUES_KEY, "Compiler issues", domain, langPropertiesKey, metrics);
+    addSensorMetric(Key.VC_SENSOR_ISSUES_KEY, "VC compiler issues", domain, langPropertiesKey, metrics);


VC compiler issues IMHO

guwirth · 2018-08-07T12:00:19Z

@ivangalkin

@guwirth the following diff is mandatory. Should I push it as a small fix right-away? or will you include it in your PR? In any way the bug should be fixed before the next release. Thank you.

Please create an own PR. Think takes longer to finalize this one:

default values
regex group names
compatibility
...

guwirth · 2018-08-13T12:40:25Z

@ivangalkin need an regex expert :-).

Like to introduce named groups for the regex parser. What's the best approach to:

read a complete file with an encoding
search for an regex
use named groups instead of index

MatchResult does not support named groups.
Pattern is Pattern.MULTILINE, so reading it line by line is also not working.

Current code:

 try (Scanner scanner = new Scanner(report, reportCharset)) {
      Pattern p = Pattern.compile(reportRegEx, Pattern.MULTILINE);
      LOG.info("Using pattern : '{}'", p);
      while (scanner.findWithinHorizon(p, 0) != null) {
        MatchResult match = scanner.match();
        String filename = alignFilename(match.group(gFn).trim());
        String line = alignLine(match.group(gLine).trim());
        String id = alignId(match.group(gId).trim());
        String msg = alignMessage(match.group(gMsg).trim());
        if (isInputValid(filename, line, id, msg)) {
          if (LOG.isDebugEnabled()) {
            LOG.debug("Scanner-matches file='{}' line='{}' id='{}' msg={}", filename, line, id, msg);
          }
          CxxReportIssue issue = new CxxReportIssue(id, filename, line, msg);
          saveUniqueViolation(context, issue);
        } else {
          LOG.warn("Invalid compiler warning: '{}''{}'", id, msg);
        }
      }

ivangalkin · 2018-08-16T20:48:49Z

Hi @guwirth,

unfortunately, I am not a big regex expert (TBH I am not a big Java expert either), but I'll try to help:

read a complete file with an encoding + search for an regex: according to what I read, usage of java.util.Scanner seems to be a good choice. Scanner doesn't load the whole file into the memory, but rather buffers it and matches chunk-by-chunk (see https://stackoverflow.com/questions/10336478/does-the-scanner-class-load-the-entire-file-into-memory-at-once). So in case of large compiler logs, this should be less memory-intensive.
use named groups instead of index: I don't have anything special to mention here. There are a couple of simple examples, which might be helpful.

The only a little bit confusing pattern I found in your code snippet is match.group(<group name>).trim(). Why do we have to use trim()? Cannot we implement a group regexp in the way, that it doen't have leading/trailing spaces? E.g like https://stackoverflow.com/questions/38934328/regex-match-a-string-without-leading-and-trailing-spaces. But that's a minor comment.

guwirth · 2018-09-10T09:13:58Z

@ivangalkin, @Bertk, @jmecosta changes done - ready to review again.

ivangalkin · 2018-09-10T20:50:16Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerSensor.java

+   * @return true, if valid
+   */
+  protected boolean isInputValid(String filename, String line, String id, String msg) {
+    return !filename.isEmpty() || !line.isEmpty() || !id.isEmpty() || !msg.isEmpty();


Not sure if there are some overrides, but a warning/issue with an empty rule-ID is of no benefit at all. Same about the message IMHO.

@ivangalkin The idea of the plugin is to break if there is a configuration error and to give only warnings if there are (partial) problems with a report. So if there is one (several) wrong messages at least the other are reported.

Or what exactly do you expect in such a case?

ivangalkin · 2018-09-10T21:02:30Z

cxx-sensors/src/main/java/org/sonar/cxx/sensors/squid/CxxSquidSensor.java

+   */
+  public static final String REPORT_PATH_KEY = "compiler.reportPath";
+  public static final String REPORT_CHARSET_DEF = "compiler.charset";
+  public static final String PARSER_KEY_DEF = "compiler.parser";


the only supported value for compiler.parser is "Visual C++"; (see sonar-cxx/cxx-squid/src/main/java/org/sonar/cxx/CxxConfiguration.java). Maybe we could deprecate this property too?

@ivangalkin idea was to change only one feature with this PR and not also the "read configuration". In general there is still #1365.
@Bertk What are you thinking?

ivangalkin · 2018-09-10T21:08:08Z

sonar-c-plugin/src/main/java/org/sonar/plugins/c/CPlugin.java

@@ -339,57 +336,73 @@
  private static List<PropertyDefinition> compilerWarningsProperties() {
    String subcateg = "(4) Compiler warnings";
    return new ArrayList<>(Arrays.asList(
-      PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCompilerSensor.REPORT_PATH_KEY)
-        .name("Compiler report(s)")
+      PropertyDefinition.builder(LANG_PROP_PREFIX + CxxCompilerVcSensor.REPORT_PATH_KEY)


it looks like we don't we miss the following properties now:

public static final String REPORT_PATH_KEY = "compiler.reportPath"; public static final String REPORT_CHARSET_DEF = "compiler.charset"; public static final String PARSER_KEY_DEF = "compiler.parser";

as far as I see, they are still used in order to set the project configuration. Is it your intent to hide them?

Thx for this hint. They are really missing now.

ivangalkin · 2018-09-10T21:08:29Z

sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/CxxPlugin.java

-import org.sonar.cxx.sensors.compiler.CxxCompilerVcParser;
-import org.sonar.cxx.sensors.compiler.CxxCompilerVcRuleRepository;
-import org.sonar.cxx.sensors.compiler.CxxCompilerVcSensor;
+import org.sonar.cxx.sensors.compiler.gcc.CxxCompilerGccRuleRepository;


same for c++ plugin

guwirth · 2018-09-23T12:50:11Z

@ivangalkin I added missing UI properties "compiler.reportPath" and "compiler.charset". Please review again.

@Bertk maybe we should rename them as well (compiler => msbuild):

  public static final String REPORT_PATH_KEY = "msbuild.reportPath";
  public static final String REPORT_CHARSET_DEF = "msbuild.charset";

ivangalkin

Reviewed 13 of 27 files at r1, 8 of 13 files at r2, 1 of 5 files at r3.
Reviewable status: 22 of 26 files reviewed, 19 unresolved discussions (waiting on @guwirth, @ivangalkin, @jmecosta, and @Bertk)

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerSensor.java, line 112 at r2 (raw file):

Previously, guwirth (Günter Wirth) wrote…

@ivangalkin The idea of the plugin is to break if there is a configuration error and to give only warnings if there are (partial) problems with a report. So if there is one (several) wrong messages at least the other are reported.

Or what exactly do you expect in such a case?

Looking at the code, which uses isInputValid()...

if (isInputValid(filename, line, id, msg)) {
  ...
  CxxReportIssue issue = new CxxReportIssue(id, filename, line, msg));
  saveUniqueViolation(context, issue);
} else {
  LOG.warn("Invalid compiler warning: '{}''{}'", id, msg);
}

... I believe that isInputValid() must filter only the useful combinations of ìd, filename, line and msg

filename + linecan be theoretically empty. Such combination means an issue raised on the whole project/module
msg is optional (see documentation of NewIssueLocation::message(String))
id can never be empty, because it's used as a rule key

In my opinion the correct implementation of isInputValid() should be something like that:

protected boolean isInputValid(String filename, String line, String id, String msg) {
  // msg is optional - no need to check
  // id must be not empty
  // for filename and line we expect: either both of them are set, or both of them are missing
  return !id.isEmpty() && (filename.isEmpty() == line.isEmpty());
}

This check is nice to have, but it's not critical. The validation takes always place, inCxxIssuesReportSensor or NewIssue/NewIssueLocation at the latest (however invalid input at this step will probably abort the sensor).

cxx-sensors/src/main/java/org/sonar/cxx/sensors/compiler/CxxCompilerSensor.java, line 70 at r3 (raw file):

            saveUniqueViolation(context, issue);
          } else {
            LOG.warn("Invalid compiler warning: '{}''{}'", id, msg);

LOG.warn("Invalid compiler warning: '{}''{}'", id, msg);

add filename and line?

sonar-c-plugin/src/main/java/org/sonar/plugins/c/CPlugin.java, line 364 at r3 (raw file):

        .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
        .index(1)
        .build(),

       .build(),······

trailing whitespaces (see below too)

sonar-cxx-plugin/src/main/java/org/sonar/plugins/cxx/CxxPlugin.java, line 390 at r3 (raw file):

        .onQualifiers(Qualifiers.PROJECT, Qualifiers.MODULE)
        .index(1)
        .build(),

       .build(),······

trailing whitespaces (see below too)

ivangalkin

Reviewable status: 22 of 26 files reviewed, 17 unresolved discussions (waiting on @guwirth, @ivangalkin, @jmecosta, and @Bertk)

jmecosta · 2018-09-25T16:58:59Z

@guwirth if this is braking change, that it is. Maybe its best to get ride of
sonar.cxx.compiler.reportPath
sonar.cxx.compiler.charset
altogether.

guwirth · 2018-09-26T19:39:59Z

if this is braking change, that it is. Maybe its best to get ride of sonar.cxx.compiler.reportPath sonar.cxx.compiler.charset altogether.

Would be renamed to then

sonar.cxx.msbuild.reportPath
sonar.cxx.msbuild.charset

…ler => msbuild)

klimkin · 2018-10-18T03:12:33Z

For some reason I am unable to activate compiler rules anymore. Any idea? All other sensors activate ok.

20:09:33.581 DEBUG: 'C++ (Community) CxxCompilerGccSensor' skipped because there is no related rule activated in the quality profile
20:09:33.581 DEBUG: 'C++ (Community) CxxCompilerVcSensor' skipped because there is no related rule activated in the quality profile

.scannerwork/scanner-report/analysis.log:  - sonar.cxx.gcc.charset=yyy
.scannerwork/scanner-report/analysis.log:  - sonar.cxx.gcc.regex=xxx
.scannerwork/scanner-report/analysis.log:  - sonar.cxx.gcc.reportPath=build/build.log

guwirth · 2018-10-18T05:19:12Z

@klimkin what do you see in the rules section of the UI? Are the rules still available and activated?

klimkin · 2018-10-18T08:11:14Z

@guwirth Administration->General Settings->C++(Community) all settings are there.

Surprisingly, sonar.cxx.cppcheck.reportPath is just enough to see DEBUG logs trying to load the file. sonar.cxx.gcc.reportPath and sonar.cxx.clangtidy.reportPath do not have any effect. I was staring at cppcheck and clangtidy sensor sources for quite time and don't see anything that might cause the difference in behavior!

klimkin · 2018-10-18T08:32:30Z

Ahh, you are right. The rules were inactive by default. Thanks!

ivangalkin · 2018-10-18T10:55:21Z

I was staring at cppcheck and clangtidy sensor sources for quite time and don't see anything that might cause the difference in behavior!

@guwirth that's one more reason to make the behavior consistent: see #1527

guwirth added the enhancement label Aug 5, 2018

guwirth added this to the 1.2 milestone Aug 5, 2018

guwirth self-assigned this Aug 5, 2018

guwirth commented Aug 6, 2018

View reviewed changes

guwirth requested review from ivangalkin, Bertk and jmecosta August 6, 2018 05:40

ivangalkin suggested changes Aug 6, 2018

View reviewed changes

ivangalkin mentioned this pull request Aug 7, 2018

Fix SensorDescriptors for CxxCompiler{Gcc|Vc}Sensor #1534

Merged

guwirth added the docu request label Sep 10, 2018

guwirth requested review from ivangalkin, Bertk and jmecosta and removed request for jmecosta and Bertk September 10, 2018 09:05

ivangalkin reviewed Sep 10, 2018

View reviewed changes

guwirth added 2 commits September 23, 2018 13:44

close #1180

b30eac2

repair missing MSBuild log properties in UI

5948fc7

ivangalkin suggested changes Sep 23, 2018

View reviewed changes

ivangalkin approved these changes Sep 23, 2018

View reviewed changes

jmecosta approved these changes Sep 25, 2018

View reviewed changes

use sonar.cxx.msbuild.reportPath and sonar.cxx.msbuild.charset (compi…

05b7e78

…ler => msbuild)

guwirth merged commit d948649 into SonarOpenCommunity:master Oct 1, 2018

This was referenced Oct 1, 2018

Refactoring: each sensor should have only one unique functionality #1409

Closed

Add an regex sensor (like 'other' XML sensor) #1081

Open

Doxygen report file support #1062

Open

guwirth mentioned this pull request Nov 1, 2018

RFF: cxx plugin v1.2 & SQ7.4 #1579

Closed

guwirth deleted the sensor-vc-gcc branch December 27, 2018 18:07

		@@ -96,7 +67,7 @@ public void processReport(final SensorContext context, File report, String chars

		private static String removeMPPrefix(String fpath) {

Split compiler sensor into GCC and MSVC compiler to use it at the same time #1533

Split compiler sensor into GCC and MSVC compiler to use it at the same time #1533

Conversation

guwirth commented Aug 5, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ivangalkin left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guwirth commented Aug 7, 2018

guwirth commented Aug 13, 2018

ivangalkin commented Aug 16, 2018

guwirth commented Sep 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

guwirth commented Sep 23, 2018

ivangalkin left a comment

Choose a reason for hiding this comment

ivangalkin left a comment

Choose a reason for hiding this comment

jmecosta commented Sep 25, 2018

guwirth commented Sep 26, 2018

klimkin commented Oct 18, 2018

guwirth commented Oct 18, 2018

klimkin commented Oct 18, 2018

klimkin commented Oct 18, 2018

ivangalkin commented Oct 18, 2018

guwirth commented Aug 5, 2018 •

edited

Loading

ivangalkin left a comment •

edited

Loading