Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible fix after the types fix in rdflib #304

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Conversation

megoth
Copy link
Contributor

@megoth megoth commented Apr 29, 2020

This must not be merged into master before we have the new types merged into rdflib - linkeddata/rdflib.js#406

@megoth megoth requested a review from timbl April 29, 2020 13:28
@megoth megoth marked this pull request as draft April 29, 2020 13:28
@megoth
Copy link
Contributor Author

megoth commented Apr 30, 2020

Relies on changes in linkeddata/rdflib.js#415

@timbl
Copy link
Contributor

timbl commented Apr 30, 2020

The checks fail at the moment with

src/widgets/buttons.ts(922,15): error TS2339: Property 'toNT' does not exist on type 'Term'.

@megoth
Copy link
Contributor Author

megoth commented Apr 30, 2020

Yeah, it's relying on the changes in the various commits. I'll let you know once it's resolved.

@megoth megoth marked this pull request as ready for review April 30, 2020 18:56
@megoth megoth merged commit b8027e2 into master Apr 30, 2020
@megoth megoth deleted the rdflib-typing-fix branch April 30, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants