Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary castings and fixing types #230

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Removing unnecessary castings and fixing types #230

merged 2 commits into from
Apr 30, 2020

Conversation

megoth
Copy link
Contributor

@megoth megoth commented Apr 30, 2020

@megoth megoth requested a review from timbl April 30, 2020 11:42
@megoth megoth marked this pull request as draft April 30, 2020 11:45
timbl
timbl approved these changes Apr 30, 2020
View reviewed changes
Copy link
Contributor

@timbl timbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice to see LiveStore creep into the picture. So good to get rid of all the type castings.

@megoth megoth marked this pull request as ready for review April 30, 2020 19:02
@megoth megoth merged commit 27e9dac into master Apr 30, 2020
@megoth megoth deleted the rdflib-typing-fix branch April 30, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timbl timbl timbl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megoth @timbl