Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): tag feedback form in matomo #360

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

lionelB
Copy link
Contributor

@lionelB lionelB commented Dec 6, 2018

track event in matomo (#294)

@revolunet
Copy link
Member

👍👍👍 trop bien. faudra voir comment généraliser ça :) useMatomo ? :p

@codecov
Copy link

codecov bot commented Dec 6, 2018

Codecov Report

Merging #360 into master will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #360      +/-   ##
==========================================
+ Coverage   42.33%   42.35%   +0.02%     
==========================================
  Files          57       57              
  Lines         711      713       +2     
  Branches      104      104              
==========================================
+ Hits          301      302       +1     
- Misses        369      370       +1     
  Partials       41       41
Impacted Files Coverage Δ
...ages/code-du-travail-frontend/src/common/Answer.js 50% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b63bed...4b3880c. Read the comment docs.

@lionelB
Copy link
Contributor Author

lionelB commented Dec 7, 2018

@douglasduteil je comprend pas le retour de codecov qui met un fail la PR :(

@douglasduteil
Copy link
Contributor

@douglasduteil je comprend pas le retour de codecov qui met un fail la PR :(

Codecov veut plus de coverage sur le patch lui même.
Il indique : 33.33% of diff hit (target 42.33%)

@lionelB lionelB merged commit a0e7ad2 into master Dec 10, 2018
@lionelB lionelB deleted the lionelb/feat-tag-thumb-up branch December 10, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants