Submit message with execution proof #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrong
changed the title
relayer/cmd/generate_beacon_data.go
Outdated
Comment on lines
200
to
204
| if !inboundFixturesOnly { | ||
| err = writeJSONToFile(initialSync, fmt.Sprintf("%s/%s", pathToBeaconTestFixtureFiles, "initial-checkpoint.json")) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I think it would be cleaner and clearer to just create a new command than adding all these if !inboundFixturesOnly {.
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Co-authored-by: Clara van Staden <[email protected]>
Comment on lines
+166
to
+171
| inboundMsg.Proof.ExecutionProof = executionProof | ||
|
|
||
| logger.WithFields(logrus.Fields{ | ||
| "EventLog": inboundMsg.EventLog, | ||
| "Proof": inboundMsg.Proof, | ||
| }).Debug("Generated message from Ethereum log") |
There was a problem hiding this comment.
Can we maybe log out the containing execution header (or beacon header) hash here? For easier debugging.
There was a problem hiding this comment.
Both are sub-fields of Proof so should already be in the log.
claravanstaden
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires: Snowfork/polkadot-sdk#125