File upload support in the HttpServer. #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The most important code works but the sample needs some HTML magic to be easier to understand and use.
slaff
force-pushed
the
feature/httpserver-multipart-bodyparser
branch
from
208383c to
e0eaead
Compare
slaff
changed the title
slaff
force-pushed
the
feature/httpserver-multipart-bodyparser
branch
from
37676a9 to
0d034d1
Compare
slaff
changed the title
|
I'm running this under the emulator (#1794 required) but data isn't getting into rBootItemOutputStream... |
Thanks for noticing this. Fetch the latest version of this PR and try again. Should work now. |
|
I like this PR :-) Potentially extremely useful. |
`useValue` remains set after parsing `Content-Disposition`, fails in `Content-Type` and aborts the entire thing.
With extra debug we now get this:
```
8969445 TCP received: 536 bytes
8969445 TCP onReadyToSendData: 1
8969445 The headers are complete
8969445 Mapped 'firmware' @ 0x00002000
8970422 TCP received: 107 bytes
8970422 TCP onReadyToSendData: 1
8972374 partBegin
8972374 readHeaderName('Content-Disposition')
8972374 readHeaderValue('form-data; name="firmware"; filename="App_Common.c"')
8972374 parser->name = 'firmware'
8972374 readHeaderName('Content-Type')
8972374 readHeaderValue('text/x-csrc')
8972374 partData(2 bytes)
flashmem_write: 0x00002000, 0
8972374 rboot_write_flash: item.size: 3
8973351 partData(2 bytes)
flashmem_write: 0x00002000, 4
8973351 rboot_write_flash: item.size: 5
8973351 partData(0 bytes)
8973351 rboot_write_flash: item.size: 5
8973351 partData(2 bytes)
flashmem_write: 0x00002004, 0
8973351 rboot_write_flash: item.size: 7
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.