Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease latency in MqttClient publishing. #1761

Merged
merged 4 commits into from
Jul 14, 2019
Merged

Decrease latency in MqttClient publishing. #1761

merged 4 commits into from
Jul 14, 2019

Conversation

slaff
Copy link
Contributor

@slaff slaff commented Jul 12, 2019

Work around for #1760.
Closes #551
Credits @verybadsoldier.

@slaff slaff added this to the 3.9.0 milestone Jul 12, 2019
@slaff slaff force-pushed the feature/force-tcp-sending branch from 8d0600f to 4a41eea Compare July 12, 2019 07:19
@verybadsoldier
Copy link
Contributor

Thanks, I will test it later!

@slaff slaff force-pushed the feature/force-tcp-sending branch 2 times, most recently from 704099a to 306e400 Compare July 12, 2019 09:52
@slaff slaff force-pushed the feature/force-tcp-sending branch from 306e400 to be21307 Compare July 12, 2019 10:08
@verybadsoldier
Copy link
Contributor

Looking good to me!

221120385 Let's publish message now. Memory free=
221121048 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
221122223 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
221141526 Message with id 12 and QoS 1 was delivered successfully.
241120390 Let's publish message now. Memory free=
241121106 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
241122221 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
241136641 Message with id 13 and QoS 1 was delivered successfully.
261120390 Let's publish message now. Memory free=
261121118 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
261122266 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
261140878 Message with id 14 and QoS 1 was delivered successfully.
281120385 Let's publish message now. Memory free=
281121053 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
281122190 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
281135268 Message with id 15 and QoS 1 was delivered successfully.
301120390 Let's publish message now. Memory free=
301121102 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
301122217 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
301137785 Message with id 16 and QoS 1 was delivered successfully.
321120390 Let's publish message now. Memory free=
321121116 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
321122219 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
321133527 Message with id 17 and QoS 1 was delivered successfully.
341120390 Let's publish message now. Memory free=
341121119 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
341122273 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
341138419 Message with id 18 and QoS 1 was delivered successfully.
361120390 Let's publish message now. Memory free=
361121119 TCP Written: 66, Available: 66, isFinished: 1, PushCount: 1 [TcpBuf: 2714]
361122267 TCP Written: 55, Available: 55, isFinished: 1, PushCount: 1 [TcpBuf: 2659]
361137342 Message with id 19 and QoS 1 was delivered successfully.

Latency <1 ms 👍

@slaff
Copy link
Contributor Author

slaff commented Jul 13, 2019

Looking good to me!

Wonderful! Please, test it during the weekend. I have to check it with wireshark and other network analysis tools and if nothing suspicious pops-up will merge it next week..

@slaff slaff changed the title Work-around to decrease latency in MqttClient publishing. Decrease latency in MqttClient publishing. Jul 13, 2019
@slaff slaff merged commit 1206f75 into SmingHub:develop Jul 14, 2019
slaff added a commit to slaff/Sming that referenced this pull request Jul 14, 2019
@slaff @slav-at-attachix
Decrease latency in MqttClient publishing. (SmingHub#1761)
4625930
slaff added a commit to slaff/Sming that referenced this pull request Jul 14, 2019
@slaff @slav-at-attachix
Decrease latency in MqttClient publishing. (SmingHub#1761)
c5154d1
slaff added a commit that referenced this pull request Jul 15, 2019
@slaff
Decrease latency in MqttClient publishing. (#1761) (#1767)
6394e55
@slaff slaff deleted the feature/force-tcp-sending branch July 22, 2019 12:44
@slaff slaff mentioned this pull request Sep 28, 2019
Closed
4 tasks
@mikee47 mikee47 mentioned this pull request Nov 4, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Port-to-LTS
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@slaff @verybadsoldier @slav-at-attachix