Revert to default MAC string format for getMAC method...
#1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntClass` and `StationClass` Fixes SmingHub#1583, so by default reverts to previous behaviour, but supports alternative formats.
mikee47
force-pushed
the
fix/MAC_formatting
branch
from
df48b27 to
5b2df92
Compare
slaff
reviewed
Jan 29, 2019
| * @retval String WiFi AP MAC address | ||
| */ | ||
| String getMAC(); | ||
| String getMAC(char sep = '\0'); |
There was a problem hiding this comment.
as 00:11:22:aa:bb:cc, while previously they returned it as 001122aabbcc
@mikee47 Shouldn't the delimiter be an empty string '' , instead of '\0' ?
There was a problem hiding this comment.
No, see makeHexString() in Data/HexString.cpp
juppin
pushed a commit
to juppin/Sming
that referenced
this pull request
Feb 1, 2019
…ntClass` and `StationClass` (SmingHub#1584) By default reverts to previous behaviour, but supports alternative formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...in
AccessPointClassandStationClassFixes #1583, so by default reverts to previous behaviour, but supports alternative formats.