Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{StationClass,AccessPointClass}::getMAC - undocumented change in behaviour #1583

Closed
q3k opened this issue Jan 28, 2019 · 1 comment
Closed

{StationClass,AccessPointClass}::getMAC - undocumented change in behaviour #1583

q3k opened this issue Jan 28, 2019 · 1 comment
Milestone
3.8.0

Comments

@q3k
Copy link

q3k commented Jan 28, 2019

483f3bf changed the behaviour of the getMAC methods on AccessPointClass and StationClass - they now return a MAC address as 00:11:22:aa:bb:cc, while previously they returned it as 001122aabbcc. This is a sudden API change on the master branch, seemingly undocumented.

In my opinion, the behaviour change should be rolled back, as it breaks applications that rely on a fixed format of the MAC for identification. I have discovered this due to an application breaking in this exact way.

Preferably, an alternative/extended method would return a MAC object that can be rendered as a string in different formats...
mikee47 added a commit to mikee47/Sming that referenced this issue Jan 28, 2019
@mikee47
Revert to default MAC string format for getMAC method in `AccessPoi…
df48b27 
…ntClass` and `StationClass`

Fixes SmingHub#1583, so by default reverts to previous behaviour, but supports alternative formats.
@mikee47 mikee47 mentioned this issue Jan 28, 2019
Merged
mikee47 added a commit to mikee47/Sming that referenced this issue Jan 29, 2019
@mikee47
Revert to default MAC string format for getMAC method in `AccessPoi…
5b2df92 
…ntClass` and `StationClass`

Fixes SmingHub#1583, so by default reverts to previous behaviour, but supports alternative formats.
@slaff slaff added this to the 3.7.2 milestone Jan 29, 2019
@slaff
Copy link
Contributor

slaff commented Jan 29, 2019

@q3k Can you check if the fix is working for you? The updated code is only in the develop branch until we release a new version.

@slaff slaff mentioned this issue Feb 27, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

No branches or pull requests
2 participants
@slaff @q3k