Ported from esp8266/Arduino i2c HAL and Wire library #1061
Conversation
Ported from esp8266/Arduino i2c HAL, faster by direct pin manipulation not via digitalWrite, some additional features of i2c bus implemented
| } | ||
|
|
||
| TwoWire Wire = TwoWire(I2C_DEFAULT_SCL_PIN, I2C_DEFAULT_SDA_PIN); | ||
| void TwoWire::onReceive( void (*function)(int) ){ | ||
| //user_onReceive = function; |
There was a problem hiding this comment.
Why the onReceive callback stuff is commented out?
There was a problem hiding this comment.
This is PORT of the library with as minimum changes as possible. May be we should import it as is, try how it works and then add more useful stuff to it as delegates etc??
| }; | ||
|
|
||
| #if !defined(NO_GLOBAL_INSTANCES) && !defined(NO_GLOBAL_TWOWIRE) | ||
| extern TwoWire Wire; |
There was a problem hiding this comment.
It would be better, memory wise, to avoid creating global objects. Therefore I would prefere the global instance to be created only if requested (in the code above it is created by default).
There was a problem hiding this comment.
Creating default Wire object is "good?? old Arduino practice" so I think we should not invent wheel and disable this. IMHO.
There was a problem hiding this comment.
Yes, also if no-one uses the Wire object, linker will not include it in final binary so no memory impact
| public: | ||
| TwoWire(); | ||
| void begin(int scl, int sda); | ||
| void pins(int scl, int sda); |
There was a problem hiding this comment.
pins() is deprecated in https://github.com/esp8266/Arduino/blob/master/libraries/Wire/Wire.h#L54
There was a problem hiding this comment.
Yes, deprecated, but it widely used in our samples and it do not hurts, so IMHO it should be included. Moreover, I changed SCL/SDA definition order from original SDA,SCL to used now in samples//libs/etc SCL/SDA.
There was a problem hiding this comment.
This will require porting for more hw libs as the argument order is reversed - or writing compat layers on top. Keeping compatibility with Arduino will make drop-in replacement for Wire.h. Hard to say what will be better although I don't mind writing some code to make existing lib working.
There was a problem hiding this comment.
Yes, we should decide either rewrite current samples/libs to use SDA/SCL pin order or rewrite every next lib with Wire. Even after my change of pin order I think it was mistake. Better change pin order in known list of our samples/libs and our own code and then have compatibility with Arduino. Comments are welcome! Thank you @zgoda to point this issue!
…Wire.pins parameters to match the [Arduino order](samples/DS3232RTC_NTP_Setter/app/application.cpp). Related to SmingHub#1179 and SmingHub#1061. Warning: this is a backward incompatible change.
Ported from esp8266/Arduino i2c HAL, faster by direct pin manipulation
not via digitalWrite, some additional features of i2c bus implemented
Wire library implement some additional features such setClock.
Looks like being fully compatible with former implementation of both i2c HAL and Wiring lib.
Tested with DS3232RTC_NTP_Setter, LiquidCrystal_44780 samples and my app with MCP23017