Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Data Fixer #701

Merged
merged 8 commits into from
May 13, 2024
Merged

Config Data Fixer #701

merged 8 commits into from
May 13, 2024

Conversation

AzureAaron
Copy link
Collaborator

Automatically converts the config file to the v2 format if it's in the v1 format. Note that if the migration is successful the old v1 data is overwritten so you cannot go back. If the DFU fails for some reason your configs will be reset however your old config will attempt (and almost certainly because idk how it could fail) be saved in a skyblocker-1.json file to allow retrieval of important data.

This also migrates the QuickNav buttons from using Item NBT to now using item components. (And removed the quick nav config class that was duplicated inside itself)

The data fixer will be removed sometime after the foraging update releases (3 weeks) at which point we expect most people to have updated to a skyblocker version with the v2 config format, those who do not update in time will lose their configs.

Important Note: The fixer expects that the config is at least from around 1.14 or newer (but ideally post-YACL), anything older and it may not work; those who haven't updated the mod since this point are on their own if they do not meet this requirement.

@AzureAaron AzureAaron added the high priority This issue or PR is prioritized, likely due to a significant loss of a function. label May 10, 2024
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label May 10, 2024
Skyblocker's Version of DFU
Copy link
Member

@LifeIsAParadox LifeIsAParadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only "Starred Mob Bounding Boxes" option was not converted correctly

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels May 10, 2024
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels May 10, 2024
@AzureAaron
Copy link
Collaborator Author

Only "Starred Mob Bounding Boxes" option was not converted correctly

Fixed now, accidentally misspelt bounding.

Copy link
Collaborator Author

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it again with DFU stuff and it works

Copy link
Member

@LifeIsAParadox LifeIsAParadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️🍞

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels May 13, 2024
@AzureAaron AzureAaron merged commit 2d1b82d into master May 13, 2024
1 check passed
@AzureAaron AzureAaron deleted the datafixer branch May 13, 2024 20:11
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label May 13, 2024
@kevinthegreat1 kevinthegreat1 removed the bleeding edge This PR has been accepted into bleeding edge label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority This issue or PR is prioritized, likely due to a significant loss of a function.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants