Quick Nav Refactor and Clean Up, 2 Extra Tabs, Config Version 3, Config Data Fixer Refactor, Debug Dump Hovered Item Tool #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LifeIsAParadox
added
reviews needed
kevinthegreat1
added
the
bleeding edge
|
Thank you for your pull request. This is a great pr but there seems to be some slight disagreement due to the reordering of this feature. In addition with the large volume of pr's we have right now, please allow some time for review. Your pr has been put in bleeding edge, and you can download the newest bleeding edge build here. |
|
I think I've added a working config for disabling the extra tabs, I'm sure the codes straight spaghetti but ¯_(ツ)_/¯ |
|
I said this on discord but just so the information is on GitHub too: Since this restructures the config, we're waiting until 1.20.5 is merged and will include this when we overhaul the config, to not mess up people's quick nav configs, which will likely be the next update. Marking as wip for now. |
kevinthegreat1
added
wip
LifeIsAParadox
added
merge conflicts
kevinthegreat1
removed
the
bleeding edge
|
Conflicts with datafixer pr. Will need to wait for #701 to be merged. |
kevinthegreat1
added
good first issue
|
Hey can you please do a quick rebase? Then I can add the config shifting and data fixer stuff, unless you want to do it. |
kevinthegreat1
added
changes requested
|
Basically rewrote quick nav. |
kevinthegreat1
added
the
bleeding edge
kevinthegreat1
previously approved these changes
May 18, 2024
LifeIsAParadox
added
merge me please
LifeIsAParadox
added
reviews needed
kevinthegreat1
previously approved these changes
May 18, 2024
LifeIsAParadox
added
merge me please
AzureAaron
previously requested changes
May 19, 2024
src/main/java/de/hysky/skyblocker/skyblock/quicknav/QuickNav.java
Outdated
Show resolved
Hide resolved
LifeIsAParadox
added
changes requested
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
May 20, 2024
LifeIsAParadox
added
merge me please
kevinthegreat1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added 2 extra quick nav tabs and tweaked rendering to accommodate the new tabs