Bump libwally-core to 0.8.6 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jurvis Tested this with nthKey. |
jurvis
reviewed
Nov 24, 2022
LibWally/PSBT.swift
Outdated
| @@ -89,6 +89,8 @@ public struct PSBTInput { | |||
| } | |||
|
|
|||
| public struct PSBTOutput : Identifiable { | |||
| let wally_psbt: wally_psbt // Since libwally-core v0.8.6 getters require the top-level psbt object | |||
| let index: Int | |||
There was a problem hiding this comment.
doesn't seem like we use index outside of the initializer -- do we need a new property here?
There was a problem hiding this comment.
Good point, I dropped both index and wally_psbt properties.
The secp256k1-zkp submodule at CLibWally/libwally-core/src/secp256k1 is updated along with libwally-core. In build-libwally.sh script we switch back to a vanilla libwally at the same commit that Bitcoin Core uses. Although Bitcoin Core bumped that commit a few months ago, we don't change it here because secp256k1-zkp has not yet been rebased on it. There were two breaking change in libwally-core: 1. wally_psbt_from_bytes got an additional FLAGS argument in 0fb94751def8b2c767680e2428ebe2fdabd436c7 (ElementsProject/libwally-core#336): trivially fixed by setting it to 0 2. wally_psbt_output no longer has a witness_script field as of 8f8481a3c509fc4a02425db3839f92594e6ea852 (ElementsProject/libwally-core#330). This required a more tedious workaround.
Sjors
force-pushed
the
2022/11/wally-core-0.8.6
branch
from
8118921 to
d7c12bc
Compare
jurvis
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secp256k1-zkp submodule at CLibWally/libwally-core/src/secp256k1 is updated along with libwally-core. In build-libwally.sh script we switch back to a vanilla libwally at the same commit that Bitcoin Core uses.
Although Bitcoin Core bumped that commit a few months ago, we don't change it here because secp256k1-zkp has not yet been rebased on it.
There were two breaking change in libwally-core:
wally_psbt_from_bytes got an additional FLAGS argument in 0fb94751def8b2c767680e2428ebe2fdabd436c7 (PSBT/PSET updates ElementsProject/libwally-core#336): trivially fixed by setting it to 0
wally_psbt_output no longer has a witness_script field as of 8f8481a3c509fc4a02425db3839f92594e6ea852 (PSBT v2 ElementsProject/libwally-core#330). This required a more tedious workaround.