PSBT/PSET updates #336
Merged
PSBT/PSET updates #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jgriffiths
commented
Oct 6, 2022
jgriffiths
commented
- Support input explicit value and asset proofs, add a helper to generate them
- Verify input and output proofs when parsing
- Add a strict parsing mode to work around elements compatibility requiring dumb/dangerous behaviour
- Some minor fixes
- Update docs, bump version for release
The PSET spec (in particular) defines several states that are invalid at the protocol level, such as fields being mutually exclusive. Elements does not enforce these invariants during serialization which is potentially dangerous. Default to Elements compatibility but allow the user to request strict validation using WALLY_PSBT_PARSE_FLAG_STRICT.
Co-authored-by: Leonardo Comandini <[email protected]>
jgriffiths
force-pushed
the
psbt_v2_merge
branch
from
b1b7b05 to
26f588f
Compare
Sjors
added a commit
to Sjors/libwally-swift
that referenced
this pull request
Nov 24, 2022
The secp256k1-zkp submodule at CLibWally/libwally-core/src/secp256k1 is updated along with libwally-core. In build-libwally.sh script we switch back to a vanilla libwally at the same commit that Bitcoin Core uses. Although Bitcoin Core bumped that commit a few months ago, we don't change it here because secp256k1-zkp has not yet been rebased on it. There were two breaking change in libwally-core: 1. wally_psbt_from_bytes got an additional FLAGS argument in 0fb94751def8b2c767680e2428ebe2fdabd436c7 (ElementsProject/libwally-core#336): trivially fixed by setting it to 0 2. wally_psbt_output no longer has a witness_script field as of 8f8481a3c509fc4a02425db3839f92594e6ea852 (ElementsProject/libwally-core#330). This required a more tedious workaround.
Sjors
added a commit
to Sjors/libwally-swift
that referenced
this pull request
Nov 25, 2022
The secp256k1-zkp submodule at CLibWally/libwally-core/src/secp256k1 is updated along with libwally-core. In build-libwally.sh script we switch back to a vanilla libwally at the same commit that Bitcoin Core uses. Although Bitcoin Core bumped that commit a few months ago, we don't change it here because secp256k1-zkp has not yet been rebased on it. There were two breaking change in libwally-core: 1. wally_psbt_from_bytes got an additional FLAGS argument in 0fb94751def8b2c767680e2428ebe2fdabd436c7 (ElementsProject/libwally-core#336): trivially fixed by setting it to 0 2. wally_psbt_output no longer has a witness_script field as of 8f8481a3c509fc4a02425db3839f92594e6ea852 (ElementsProject/libwally-core#330). This required a more tedious workaround.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.