Feature/metrics chart #4
Conversation
SivaprasadAluri
force-pushed
the
feature/metricsChart
branch
3 times, most recently
from
6956037 to
febd159
Compare
| AGGREGATIONS, | ||
| GROUPBY, | ||
| METRICS_AGGREGATION_OPTIONS, | ||
| numericalTypes, |
There was a problem hiding this comment.
Change numericalTypes to NUMERICAL_TYPES. This change has been merged to main. Please check.
| ...userConfigs?.dataConfig, | ||
| }); | ||
| } | ||
| }, [userConfigs, userConfigs?.dataConfig, visualizations.vis.name]); |
There was a problem hiding this comment.
Do we need the dependency of userConfigs also?
| top: 20px; | ||
| text-align: center; | ||
| width: '100%' | ||
| } |
There was a problem hiding this comment.
Add new line at the end of file
SivaprasadAluri
force-pushed
the
feature/metricsChart
branch
2 times, most recently
from
4655498 to
d8845dd
Compare
SivaprasadAluri
force-pushed
the
feature/metricsChart
branch
from
d8845dd to
ff477c2
Compare
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
Signed-off-by: SivaprasadAluri <[email protected]>
SivaprasadAluri
force-pushed
the
feature/metricsChart
branch
from
076b0f4 to
da4f2bf
Compare
| }; | ||
|
|
||
| const handleServiceRemove = (index: number, name: string) => { | ||
| const arr = [...configList[name]]; |
There was a problem hiding this comment.
Provide proper name for the variable arr.
| <EuiTitle size="xxs"> | ||
| <h3>Series</h3> | ||
| </EuiTitle> | ||
| {getCommonUI(configList.series, 'series')} |
There was a problem hiding this comment.
Replace series with the constant [AGGREGATIONS]
| const { | ||
| data, | ||
| metadata: { fields }, | ||
| } = visualizations.data.rawVizData; |
There was a problem hiding this comment.
Can destructure the object as in other visualizations.
| <div className="metricsContainer"> | ||
| <h4 className="metricTitle"> {dataTitle} </h4> | ||
| <div> | ||
| {dataConfig && dataConfig?.series?.length > 0 ? ( |
There was a problem hiding this comment.
Try to access series with a constant
| </div> | ||
| <div className="aggregateLabel" style={{ fontSize: fontSize / 2 + 'px' }}> | ||
| <span> {aggFunction.label} </span> | ||
| {metric.alias !== '' ? metric.alias : metric.label} |
There was a problem hiding this comment.
From alias everything is changed to custom label. For consistency please change it everywhere required.
Signed-off-by: SivaprasadAluri <[email protected]>
Description
Added Metrics Charts Styles Panel
Issues Resolved
Metrics Chart opensearch-project#872