updated the review comments

Signed-off-by: SivaprasadAluri <[email protected]>
SivaprasadAluri · Oct 3, 2022 · d8845dd · d8845dd
1 parent fce9f1a
commit d8845dd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...rer/visualizations/config_panel/config_panes/config_controls/metric_config_panel_item.tsx b/...rer/visualizations/config_panel/config_panes/config_controls/metric_config_panel_item.tsx
@@ -22,7 +22,7 @@ import {
   AGGREGATIONS,
   GROUPBY,
   METRICS_AGGREGATION_OPTIONS,
-  numericalTypes,
+  NUMERICAL_TYPES,
 } from '../../../../../../../../common/constants/explorer';
 import { VIS_CHART_TYPES } from '../../../../../../../../common/constants/shared';
 import { MetricList, MetricListEntry } from '../../../../../../../../common/types/explorer';
@@ -54,7 +54,7 @@ export const MetricConfigPanelItem = ({ fieldOptionList, visualizations }: any)
         ...userConfigs?.dataConfig,
       });
     }
-  }, [userConfigs, userConfigs?.dataConfig, visualizations.vis.name]);
+  }, [userConfigs?.dataConfig, visualizations.vis.name]);
 
   const updateList = (value: string, index: number, name: string, field: string) => {
     const listItem = {
@@ -128,7 +128,7 @@ export const MetricConfigPanelItem = ({ fieldOptionList, visualizations }: any)
       }
     }
     return fieldOptionList.filter(
-      (field) => !selectedFields[field.label] && numericalTypes.includes(field.type)
+      (field) => !selectedFields[field.label] && NUMERICAL_TYPES.includes(field.type)
     );
   };
 

diff --git a/dashboards-observability/public/components/visualizations/charts/metrics/metrics.scss b/dashboards-observability/public/components/visualizations/charts/metrics/metrics.scss
@@ -36,4 +36,4 @@
     top: 20px;
     text-align: center;
     width: '100%'
-}
+}