Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R109 #901

Merged
merged 5 commits into from
Aug 26, 2021
Merged

Implement SIA-R109 #901

merged 5 commits into from
Aug 26, 2021

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Aug 25, 2021

Prototype implementation of HTML page language subtag matches default language to explore how backend can automatically grab questions answer.

@Jym77 Jym77 requested a review from kasperisager August 25, 2021 11:14
@Jym77 Jym77 self-assigned this Aug 25, 2021
kasperisager
kasperisager previously requested changes Aug 25, 2021
View reviewed changes
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r109/rule.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 requested a review from kasperisager August 25, 2021 13:41
@Jym77 Jym77 enabled auto-merge (squash) August 26, 2021 12:02
@Jym77 Jym77 merged commit a87fd94 into main Aug 26, 2021
@Jym77 Jym77 deleted the implement-sia-r109 branch August 26, 2021 12:06
@kasperisager kasperisager added the minor Backwards-compatible change that touches public API label Aug 26, 2021
kasperisager added a commit that referenced this pull request Sep 2, 2021
@kasperisager
Merge branch 'main' into tuple
5fafcb7 
* main: (21 commits)
  Implement SIA R76 (#910)
  Update CODEOWNERS
  Update `tar`
  Implement SIA-R109 (#901)
  Support `text-align` CSS property (#899)
  Implement SIA-R70 (#870)
  Implement SIA-R60 (#874)
  v0.21.2
  Update changelog
  Don't count invisible text as possibly wrapped in SIA-R83 (#898)
  Avoid test files being included by `yarn pack`
  v0.21.1
  Update changelog
  Reject empty text nodes in SIA-R75 (#896)
  Use separate concurrency groups for workflows
  Use `github.ref` instead of `github.head_ref`
  Limit concurrency of workflows
  Update API reviews
  Exclude `node_modules` in build scripts
  Mark `I` as `Readonly` in `Rule.Evaluate`
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvy-siteimprove mvy-siteimprove mvy-siteimprove left review comments

@kasperisager kasperisager kasperisager approved these changes

Assignees

@Jym77 Jym77

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jym77 @kasperisager @mvy-siteimprove