Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R70 #839

Closed
wants to merge 11 commits into from
Closed

Implement SIA-R70 #839

wants to merge 11 commits into from

Conversation

elenamongelli
Copy link
Contributor

@elenamongelli elenamongelli commented Jun 21, 2021 •
edited
Loading

Closes #826

@kasperisager kasperisager changed the title Implementation of rule 70: Implement SIA-R70 Jun 22, 2021
@kasperisager kasperisager added the minor Backwards-compatible change that touches public API label Jun 22, 2021
@elenamongelli elenamongelli marked this pull request as ready for review June 23, 2021 10:20
Jym77
Jym77 previously requested changes Jun 25, 2021
View reviewed changes
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Show resolved Hide resolved
packages/alfa-rules/test/sia-r70/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r70/rule.spec.tsx Outdated Show resolved Hide resolved
packages/alfa-rules/test/sia-r70/rule.spec.tsx Outdated Show resolved Hide resolved
@elenamongelli elenamongelli requested a review from Jym77 June 25, 2021 12:00
Jym77
Jym77 previously requested changes Jun 29, 2021
View reviewed changes
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
@Jym77
Copy link
Contributor

Jym77 commented Jul 2, 2021

Also, the rule needs to be activated in packages/alfa-rules/src/rules.ts. See #850

@elenamongelli elenamongelli dismissed Jym77’s stale review July 5, 2021 13:30

Changes implemented

@elenamongelli elenamongelli requested a review from Jym77 July 5, 2021 13:30
kasperisager
kasperisager previously requested changes Jul 6, 2021
View reviewed changes
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
@elenamongelli elenamongelli dismissed kasperisager’s stale review July 8, 2021 10:32

comments implemented

kasperisager
kasperisager previously requested changes Jul 8, 2021
View reviewed changes
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/sia-r70/rule.ts Outdated Show resolved Hide resolved
@elenamongelli elenamongelli dismissed kasperisager’s stale review July 20, 2021 11:32

Changes implemented

@Jym77 Jym77 force-pushed the Implement-SIA-R70 branch from d2a83c8 to 2ee9b98 Compare July 21, 2021 09:00
@Jym77 Jym77 mentioned this pull request Jul 21, 2021
Merged
@Jym77
Copy link
Contributor

Jym77 commented Jul 21, 2021

PR got botched during rebase (?). Closing in favour of #870.

@Jym77 Jym77 closed this Jul 21, 2021
@Jym77 Jym77 deleted the Implement-SIA-R70 branch August 18, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jym77 Jym77 Awaiting requested review from Jym77

@kasperisager kasperisager Awaiting requested review from kasperisager

Assignees

@elenamongelli elenamongelli

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement SIA-R70
3 participants
@elenamongelli @Jym77 @kasperisager