Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SIA-R70 #826

Closed
Jym77 opened this issue Jun 8, 2021 · 0 comments · Fixed by #870
Closed

Implement SIA-R70 #826

Jym77 opened this issue Jun 8, 2021 · 0 comments · Fixed by #870
Assignees
@elenamongelli

Comments

@Jym77
Copy link
Contributor

Jym77 commented Jun 8, 2021 •
edited
Loading

https://github.com/Siteimprove/sanshikan/blob/df450e27db11c4d7b36eb1d53fa0aecdb0f729ba/rules/sia-r70.md

Applicability:

  • take inspiration from, e.g., R59 or R87 (both do the same thing in different ways…)

Expectation:

  • Use descendants(), flat tree is obtained with options flattened and nested. See, e.g. Applicability of R2.
  • use isVisible and not(isIgnored)
  • Get inspiration from R1 (expectation) for grabbing elements by their name. hasName can take several arguments.

Extended diagnostic:

  • We need to send the list of offending elements we've found.
@Jym77 Jym77 changed the title Implement R70 Implement SIA-R70 Jun 9, 2021
@Jym77 Jym77 mentioned this issue Jun 25, 2021
Closed
@Jym77 Jym77 mentioned this issue Jul 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elenamongelli elenamongelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement SIA-R70 Siteimprove/alfa
Implement SIA-R70 Siteimprove/alfa
2 participants
@Jym77 @elenamongelli