Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): Allow importing agent file with empty description #8670

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix(frontend): Allow importing agent file with empty description #8670

merged 3 commits into from
Nov 18, 2024

Conversation

Pwuts
Copy link
Member

@Pwuts Pwuts commented Nov 15, 2024 •
edited
Loading

Changes 🏗️

  • Check structure of agent file with obj[key] != null rather than !!obj[key] to allow empty strings

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Make an agent with an empty description; export and import it
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@Pwuts Pwuts requested a review from a team as a code owner November 15, 2024 14:37
@Pwuts Pwuts requested review from Bentlybro and kcze and removed request for a team November 15, 2024 14:37
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end size/s labels Nov 15, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2024 •
edited
Loading

✅ Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 49819b5
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/673bd1bb2dbdce00086528f6

@Pwuts Pwuts enabled auto-merge (squash) November 15, 2024 14:38
@Pwuts Pwuts merged commit e81083d into dev Nov 18, 2024
15 checks passed
@Pwuts Pwuts deleted the reinier/open-2044-agent-import-fails-with-empty-description branch November 18, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarushik93 aarushik93 aarushik93 approved these changes

@Bentlybro Bentlybro Awaiting requested review from Bentlybro Bentlybro is a code owner automatically assigned from Significant-Gravitas/maintainers

@kcze kcze Awaiting requested review from kcze kcze is a code owner automatically assigned from Significant-Gravitas/maintainers

Assignees
No one assigned
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pwuts @aarushik93 @Torantulino