Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix input-field update on empty & default value #8647

Conversation

majdyz
Copy link
Contributor

@majdyz majdyz commented Nov 14, 2024

There are three different issues:

Changes 🏗️

Fixed the mentioned issues above.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@majdyz majdyz requested a review from a team as a code owner November 14, 2024 04:33
@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end and removed Review effort [1-5]: 2 labels Nov 14, 2024
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis ✅

8626 - Fully compliant

Compliant requirements:

  • Fix implemented for empty string updates from input box to input field
⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Edge Case
The InputRef function modification to handle null values might need validation for edge cases with different falsy values

Type Safety
The hasNonNullNonObjectValue function accepts 'any' type which could lead to runtime errors with unexpected input types

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 0611149
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/67357e34f5fdf0000848a6d5

@Torantulino Torantulino merged commit 98ab525 into dev Nov 14, 2024
15 checks passed
@Torantulino Torantulino deleted the zamilmajdy/open-2031-deleting-all-text-from-input-popup-causes-desync-with-input branch November 14, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants