Merge login and signin #8389
Merged
Merge login and signin #8389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhi1992002
requested review from
Swiftyos and
Pwuts
and removed request for
a team
github-actions
bot
added
platform/frontend
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
✅ Deploy Preview for auto-gpt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Abhi1992002
force-pushed
the
merge-login-and-signin
branch
from
5fc833e
to
c69f3f6
Compare
ntindle
requested changes
Oct 22, 2024
|
Done..!! |
|
@Abhi1992002 same thing here regarding supabase |
This reverts commit 5b9bdfb.
github-actions
bot
added
size/xs
and removed
platform/frontend
github-actions
bot
added
platform/frontend
ntindle
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8328
Both the login and signup processes were the same, causing confusion. Now, there’s a single route for login, and if the user isn’t registered, they’ll be redirected to the signup page automatically.
Changes 🏗️
Created two separate files for login and signup.
If a user tries to log in and their email is not found in the system, they will
be redirected to the signup page.
If the user is already registered, the usual login process will proceed.
Testing 🔍
• The login flow to ensure redirection to signup if email is not present.
• Confirmed successful login for registered users.
login-signin.flow.mp4