Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci,platform): Add dev branch trigger to all ci #8339

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

aarushik93
Copy link
Contributor

@aarushik93 aarushik93 commented Oct 14, 2024

Background

We have a dev branch now

Changes πŸ—οΈ

Add dev branch trigger to all ci

Testing πŸ”

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

@aarushik93 aarushik93 requested a review from a team as a code owner October 14, 2024 19:30
@github-actions github-actions bot added the platform/backend AutoGPT Platform - Back end label Oct 14, 2024
Copy link

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Inconsistent Branch Naming
The dev branch is added inconsistently across the workflow files. In the backend CI, it's listed as dev, while in other files it's dev. This inconsistency should be addressed to ensure uniform branch naming across all CI workflows.

Copy link

netlify bot commented Oct 14, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 97c7020
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/670e3a7241a73b000850f63b

@aarushik93 aarushik93 changed the title fix(ci,platform): Add dev branch trigger to all platform ci fix(ci,platform): Add dev branch trigger to all ci Oct 14, 2024
@github-actions github-actions bot added size/m and removed size/s labels Oct 14, 2024
@aarushik93 aarushik93 enabled auto-merge (squash) October 14, 2024 19:33
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Please upload report for BASE (dev@1c71351). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev    #8339   +/-   ##
======================================
  Coverage       ?   49.62%           
======================================
  Files          ?      144           
  Lines          ?     8916           
  Branches       ?     1240           
======================================
  Hits           ?     4425           
  Misses         ?     4344           
  Partials       ?      147           
Flag Coverage Ξ”
Linux 49.43% <ΓΈ> (?)
Windows 50.03% <ΓΈ> (?)
agbenchmark 34.07% <ΓΈ> (?)
autogpt-agent 33.94% <ΓΈ> (?)
forge 58.03% <ΓΈ> (?)
macOS 48.90% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@aarushik93 aarushik93 requested a review from Pwuts October 15, 2024 09:48
Pwuts
Pwuts previously approved these changes Oct 15, 2024
@aarushik93 aarushik93 changed the base branch from master to dev October 15, 2024 09:49
@aarushik93 aarushik93 dismissed Pwuts’s stale review October 15, 2024 09:49

The base branch was changed.

@aarushik93 aarushik93 requested a review from Pwuts October 15, 2024 09:49
@aarushik93 aarushik93 merged commit a2ef456 into dev Oct 15, 2024
23 of 28 checks passed
@aarushik93 aarushik93 deleted the aarushikansal/ci-for-dev-branch branch October 15, 2024 09:57
@aarushik93
Copy link
Contributor Author

aarushik93 added a commit that referenced this pull request Oct 16, 2024
* feat(platform): List and revoke credentials in user profile (#8207)

Display existing credentials (OAuth and API keys) for all current providers: Google, Github, Notion and allow user to remove them. For providers that support it, we also revoke the tokens through the API: of the providers we currently have, Google and GitHub support it; Notion doesn't.

- Add credentials list and `Delete` button in `/profile`
- Add `revoke_tokens` abstract method to `BaseOAuthHandler` and implement it in each provider
- Revoke OAuth tokens for providers on `DELETE` `/{provider}/credentials/{cred_id}`, and return whether tokens could be revoked
   - Update `autogpt-server-api/baseClient.ts:deleteCredentials` with `CredentialsDeleteResponse` return type

Bonus:
- Update `autogpt-server-api/baseClient.ts:_request` to properly handle empty server responses

* fix(backend): Lower the number of node workers to save DB connections (#8331)

Change [graph]Γ—[node] worker limit from 10Γ—5 to 10Γ—3

---------

Co-authored-by: Reinier van der Leer <[email protected]>

* fix(ci,platform): Add dev branch trigger to all ci (#8339)

* update ci for dev

* update classic

* remove duplicate dev

* fix(frontend): Fix styling inconsistencies in input elements (#8337)

- Apply consistent border styling to `Input`, `Select`, and `Textarea`
   - Remove `rounded-xl` from node input elements

- Add `whitespace-nowrap` to `CustomNode` header category tags

---------

Co-authored-by: Zamil Majdy <[email protected]>

* feat(builder): Use configmap for builder (#8343)

use configmap in builder

* fix(platform,infra): Checkin non secret values  (#8344)

checkin non secrets

* security(platform): Add sealed secrets (#8342)

* add sealed secrets

* add encrypted secrets

* remove extra space

* Tf public media buckets (#8324)

* fix(infra): Fix sealed secret names  (#8350)

* fix sealed secret names

* fix names and add annotation

* feat(backend): Introduce executors shared DB connection (#8340)

* update health checkendpoint

---------

Co-authored-by: Krzysztof Czerwinski <[email protected]>
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
Co-authored-by: Swifty <[email protected]>
aarushik93 added a commit that referenced this pull request Oct 16, 2024
* feat(platform): List and revoke credentials in user profile (#8207)

Display existing credentials (OAuth and API keys) for all current providers: Google, Github, Notion and allow user to remove them. For providers that support it, we also revoke the tokens through the API: of the providers we currently have, Google and GitHub support it; Notion doesn't.

- Add credentials list and `Delete` button in `/profile`
- Add `revoke_tokens` abstract method to `BaseOAuthHandler` and implement it in each provider
- Revoke OAuth tokens for providers on `DELETE` `/{provider}/credentials/{cred_id}`, and return whether tokens could be revoked
   - Update `autogpt-server-api/baseClient.ts:deleteCredentials` with `CredentialsDeleteResponse` return type

Bonus:
- Update `autogpt-server-api/baseClient.ts:_request` to properly handle empty server responses

* fix(backend): Lower the number of node workers to save DB connections (#8331)

Change [graph]Γ—[node] worker limit from 10Γ—5 to 10Γ—3

---------

Co-authored-by: Reinier van der Leer <[email protected]>

* fix(ci,platform): Add dev branch trigger to all ci (#8339)

* update ci for dev

* update classic

* remove duplicate dev

* fix(frontend): Fix styling inconsistencies in input elements (#8337)

- Apply consistent border styling to `Input`, `Select`, and `Textarea`
   - Remove `rounded-xl` from node input elements

- Add `whitespace-nowrap` to `CustomNode` header category tags

---------

Co-authored-by: Zamil Majdy <[email protected]>

* feat(builder): Use configmap for builder (#8343)

use configmap in builder

* fix(platform,infra): Checkin non secret values  (#8344)

checkin non secrets

* security(platform): Add sealed secrets (#8342)

* add sealed secrets

* add encrypted secrets

* remove extra space

* Tf public media buckets (#8324)

* fix(infra): Fix sealed secret names  (#8350)

* fix sealed secret names

* fix names and add annotation

* feat(backend): Introduce executors shared DB connection (#8340)

* update health checkendpoint

---------

Co-authored-by: Krzysztof Czerwinski <[email protected]>
Co-authored-by: Reinier van der Leer <[email protected]>
Co-authored-by: Zamil Majdy <[email protected]>
Co-authored-by: Swifty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

2 participants