-
Notifications
You must be signed in to change notification settings - Fork 44.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from argparse to click for argument parsing #1184
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nponeccop
approved these changes
Apr 13, 2023
<3 click |
nponeccop
previously approved these changes
Apr 14, 2023
@0xArty There are conflicts now |
Merge conflicts fixed 👍 |
nponeccop
previously approved these changes
Apr 14, 2023
please build in the changes that have just been merged by #1096 |
@richbeales done |
@0xArty There are conflicts now |
Closed too many merge conflicts. Will coordinate this change with the team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR changes the argument parsing library from
argparse
toclick
. The primary reason for this switch is to leverage the benefits provided byclick
, while maintaining backward compatibility with the existing implementation.Click
is a powerful and flexible library for creating command-line interfaces, offering several advantages overargparse
, such as a more intuitive and consistent API, better error messages, automatic generation of help messages, and advanced features like command chaining and nested commands.Changes
Benefits of Click
Documentation
The code changes include in-code comments to describe the new click decorators and options. The external documentation will be updated to reflect the change from argparse to click.
Test Plan
PR Quality Checklist