Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed variable dropdown closing on select #6087

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

SagarRajput-7
Copy link
Contributor

Summary

Related Issues / PR's

Screenshots

Screen.Recording.2024-09-27.at.11.04.16.AM.mov

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

@SagarRajput-7, it doesn't prevent it from closing, it seems like it closes and then opens again. Why can't we make it not close in the first place and avoid jerky behaviour on each selection, which is not a good UX?

@srikanthccv
Copy link
Member

Looked at the code just out of curiosity. I do not think this is a good solution to make it open by click event.

@SagarRajput-7
Copy link
Contributor Author

Looked at the code just out of curiosity. I do not think this is a good solution to make it open by click event.

@srikanthccv - yes, that is why this PR is in work in progress, i am working on the UX and behaviour only, I just mentioned this PR there, to say that this issue is also in motion.

@srikanthccv
Copy link
Member

ok, it would have been best to keep it in the draft in that case. As you attached the video and requested for review I thought this was ready for review and the wip was about testing etc...

@SagarRajput-7 SagarRajput-7 marked this pull request as draft September 27, 2024 08:03
@SagarRajput-7 SagarRajput-7 force-pushed the variables-dropdown-closes-on-select branch 2 times, most recently from 340270d to f3ccff5 Compare October 7, 2024 16:41
@SagarRajput-7 SagarRajput-7 force-pushed the variables-dropdown-closes-on-select branch from f3ccff5 to 782e530 Compare October 14, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants