Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed all not deselecting and empty array setting to _ALL_ #6086

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

SagarRajput-7
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 commented Sep 26, 2024

Summary

Fixed:

  • Deselecting All not working
  • Deselecting a single value was setting is to All

Related Issues / PR's

Screenshots

Screen.Recording.2024-09-27.at.4.34.07.AM.mov

Affected Areas and Manually Tested Areas

  • tested dashboard variable with all selection

@github-actions github-actions bot added the bug Something isn't working label Sep 26, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv
Copy link
Member

@SagarRajput-7, please tackle the dropdown closing first. A user wants to deselect ALL so they can select something. If the dropdown closes right away without letting them select values, it's very annoying and makes the whole benefit of deselect least useful.

@SagarRajput-7
Copy link
Contributor Author

@SagarRajput-7, please tackle the dropdown closing first. A user wants to deselect ALL so they can select something. If the dropdown closes right away without letting them select values, it's very annoying and makes the whole benefit of deselect least useful.

@srikanthccv - That is also in progress, please check this - #6087

Screen.Recording.2024-09-27.at.11.04.16.AM.mov

@srikanthccv srikanthccv self-requested a review September 27, 2024 06:27
Copy link

github-actions bot commented Oct 8, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM
Copy link
Member

YounixM commented Oct 14, 2024

Please confirm that this is the expected behaviour.

@ahmadshaheer
Copy link
Collaborator

@SagarRajput-7, as I checked, deselecting a single item (if I click on the option title), selects all the checkboxes. I was wondering if this is expected

https://www.loom.com/share/4761450e448f418283498995d5bf89be

@SagarRajput-7
Copy link
Contributor Author

@SagarRajput-7, as I checked, deselecting a single item (if I click on the option title), selects all the checkboxes. I was wondering if this is expected

https://www.loom.com/share/4761450e448f418283498995d5bf89be

Yes, if you see, while selecting the option title we show a All text also there, hence it is expected to select all there.
Basically we have two options there - All and Only

@SagarRajput-7 SagarRajput-7 merged commit 80b3c3e into develop Oct 16, 2024
16 of 17 checks passed
@SagarRajput-7 SagarRajput-7 deleted the variables-all-deselect branch October 16, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants