Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #1648

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix CI #1648

merged 4 commits into from
Sep 11, 2023

Conversation

KaanOzkan
Copy link
Contributor

Motivation

Resolving CI failures https://github.com/Shopify/tapioca/actions/runs/6124704298/job/16625214068

Implementation

Reflected API changes similar to #1643

Tests

@KaanOzkan KaanOzkan requested a review from a team as a code owner September 11, 2023 14:44
Morriar
Morriar approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to require a rebase before merge?

@Tonkpils Tonkpils mentioned this pull request Sep 11, 2023
Merged
@KaanOzkan
Copy link
Contributor Author

Tests are using the latest version of YARP which isn't compatible with rbi gem. Will bump rbi once a new version with Shopify/rbi#232 is released.

@KaanOzkan KaanOzkan changed the title Use Spoom::Context API Fix CI Sep 11, 2023
@KaanOzkan KaanOzkan merged commit 59e4c13 into main Sep 11, 2023
30 checks passed
@KaanOzkan KaanOzkan deleted the ko/CI-fix branch September 11, 2023 22:07
@shopify-shipit shopify-shipit bot temporarily deployed to production September 13, 2023 22:55 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwise-aiden bitwise-aiden bitwise-aiden approved these changes

@Morriar Morriar Morriar approved these changes

@paracycle paracycle paracycle approved these changes

@vinistock vinistock Awaiting requested review from vinistock vinistock is a code owner automatically assigned from Shopify/sorbet

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KaanOzkan @paracycle @Morriar @bitwise-aiden