Use Spoom::Context instead of custom abstraction #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
st0012
approved these changes
Sep 5, 2023
vinistock
approved these changes
Sep 5, 2023
bitwise-aiden
approved these changes
Sep 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use 3 custom abstractions in our tests:
MockDir: to create directories and manipulate them, also used to create annotations repositories.MockProject: A subclass ofMockDirthat abstracts a project that would use Tapioca. It provides basic commands to register mock gems and run thetapiocacommand in the context of the project.MockGem: A subclass ofMockDirthat abstracts a gem that can be required to aMockProjectand will be loaded by Tapioca to generate RBI for.This migrate these abstraction to
Spoom::Contextthat provides similar features and much more. This completely removes the need forMockDirand simplifiesMockProjectandMockGem.One limitation of
Spoom::Contextvs.MockProjectis the way we currently set the bundler version in the context of a test.Spoom::Contextdoesn't support that at the moment. I changed the override to be marked asallow_incompatibleso we can add additional keyword arguments. I'll look into adding this feature to Spoom.This PR is easier to review commit by commit.