Update sewing-kit to 0.132.2 and storybook to 5.3.19 #3072
Conversation
BPScott
force-pushed
the
bump-sk
branch
3 times, most recently
from
fd33308 to
f63c7da
Compare
| @@ -1 +1 @@ | |||
| v10.13.0 | |||
There was a problem hiding this comment.
node versio bump as a dependency required this version of node.
|
|
||
| // babel-preset-shopify/react only uses HMR if hot is true and the env is |
There was a problem hiding this comment.
The hot option was removed in Shopify/web-configs#145.
Storybook continues to auto reload without it.
| @@ -211,8 +210,5 @@ | |||
| "hoist-non-react-statics": "^3.3.0", | |||
| "lodash": "^4.17.4", | |||
| "tslib": "^1.9.3" | |||
| }, | |||
There was a problem hiding this comment.
sewing-kit now uses prettier v2 out the box so we don't need to force the resolution anymore
| @@ -8,8 +8,6 @@ | |||
| "jsx": "react-native", | |||
| "isolatedModules": true, | |||
| "importsNotUsedAsValues": "error", | |||
| // strictFunctionTypes is implictly enabled by strict mode but | |||
There was a problem hiding this comment.
Typescript is chill with having comments in this file, but a recent SK change now tries to read this as plain json, and throws up when we have comments.
I still want to stop disabling strictFunctionTypes eventually but not now.
| @@ -68,49 +69,46 @@ describe('<FilterCreator />', () => { | |||
| }; | |||
|
|
|||
| it('focuses the activator after adding a filter', () => { | |||
| const filterCreator = mountWithAppProvider( | |||
| const filterCreator = mountWithApp( | |||
There was a problem hiding this comment.
I missed a file in #3070
package.json
Outdated
| @@ -176,7 +175,7 @@ | |||
| "serve": "^11.1.0", | |||
| "shelljs": "^0.8.3", | |||
| "shx": "^0.3.2", | |||
| "storybook-chromatic": "^3.4.1", | |||
| "storybook-chromatic": "^3.5.5", | |||
There was a problem hiding this comment.
This bump helped remove some transitive versions of jest 24 that were hanging around
There was a problem hiding this comment.
Might as well update to v5, what do you think? (the v4 upgrade was painless on polaris-styleguide, I expect it'll be the same for v5)
There was a problem hiding this comment.
done! I've bumped other storybook deps for good measure too
| "puppeteer": "^1.20.0", | ||
| "react": "^16.8.6", | ||
| "react-dom": "^16.8.6", | ||
| "react-test-renderer": "^16.3.1", | ||
| "react-test-renderer": "^16.8.6", |
There was a problem hiding this comment.
Not strictly needed but I though this would help with some test stuff but it didn't. This should be kept in sync with the version of react/react-dom anyway.
- Update references to eslint-plugin-shopify, stylelint-config-shopify, babel-preset-shopify and postcss-shopify to account for them being deprecated and moved to new packkages - Add ignores for some new rules and other linting fixes - Skip some tests in ComboBox as they cause infinine loops in Jest 25 / JSDom 16 and I'm not sure of the root cause.
BPScott
changed the title
WHY are these changes introduced?
Keeping up to date. This new SK contains:
@shopifynamespaceWHAT is this pull request doing?
Looks scary but most of this is yarn.lock updates.
babel-preset-shopify and postcss-shopify to account for them being
deprecated and moved to new packkages under thee
@shopifynamespaceJSDom 16 and I'm not sure of the root cause.
yarn-dedupeHow to 🎩
Ensure linting and tests pass, ensure HMR still works in storybook.