Update activeElement tests to use modern testing utils #3070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🟢 No significant changes to |
BPScott
force-pushed
the
prepare-for-new-sk
branch
from
c3e998e to
187b9a0
Compare
BPScott
force-pushed
the
prepare-for-new-sk
branch
from
187b9a0 to
51ec767
Compare
An imminent bump to SK and thus Jest exposes a case enzyme doesn't handle component mounting to jsdom in a way that is spec compliant, which then results in test that assert on document.activeElement failing. Fortunatly react-testing doesn't have this problem, so we can just use that instead
BPScott
force-pushed
the
prepare-for-new-sk
branch
from
51ec767 to
b1ac67b
Compare
kaelig
approved these changes
Jun 23, 2020
| @@ -257,15 +245,15 @@ describe('<TrapFocus />', () => { | |||
|
|
|||
| listenerMap.keydown({ | |||
| keyCode: Key.Tab, | |||
| target: lastNode(trapFocus), | |||
| target: trapFocus.find('input')!.domNode, | |||
There was a problem hiding this comment.
This (and a few other instances) slightly diverges from the intent of the test but I feel good about this change.
Unfortunately there is none that I am aware of. But from working through this stuff it boils down to:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
An imminent bump to SK and thus Jest exposes a case where enzyme doesn't handle component mounting to jsdom in a way that results in spec compliant focus management, which then results in tests that assert on document.activeElement failing.
Fortunately react-testing doesn't have this problem, so we can just usethat instead.
Gory details: enzymejs/enzyme#2337 (comment)
WHAT is this pull request doing?
Migrates a handful of test cases from enzyme to use react-testing
How to 🎩
Run tests and see they still pass