Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some tests #135

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Port some tests #135

merged 3 commits into from
Jun 17, 2024

Conversation

Earlopain
Copy link
Contributor

A bit for #21

There was one typo I noticed in an unrelated test where workers_per_queue => queues_per_worker. It doesn't impact the test since queues - 1 is the default value

Copy link
Contributor

@paarthmadan paarthmadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks for taking these on! Feel free to update that issue as you see fit 🙏

@casperisfine
Copy link
Contributor

here was one typo I noticed in an unrelated test where workers_per_queue => queues_per_worker.

Good catch, we probably ought to validate these and raise an error or warning.

@casperisfine casperisfine merged commit 846415a into Shopify:master Jun 17, 2024
9 of 10 checks passed
@Earlopain Earlopain deleted the port-tests branch June 17, 2024 06:20
@Earlopain
Copy link
Contributor Author

That sounds reasonable, yes. I also noticed that when I accidentally set the queues higher than the total number of workers a portion of requests just hang. queues <= number_of_workers validation may also make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants