Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: port integration tests to minitest #21

Open
11 of 17 tasks
casperisfine opened this issue Jan 31, 2023 · 0 comments
Open
11 of 17 tasks

Chore: port integration tests to minitest #21

casperisfine opened this issue Jan 31, 2023 · 0 comments
Assignees
@paarthmadan

Comments

@casperisfine
Copy link
Contributor

casperisfine commented Jan 31, 2023 •
edited
Loading

The current integration tests are inherited from Unicorn. They're very hard to debug, especially if they fail on CI.

It would be good to port them to minitest, with Ruby instead of Bash, it would be much easier to produce readable and actionable error reports.

  • t0000-http-basic
  • t0002-parser-error
  • t0004-heartbeat-timeout
  • t0009-broken-app
  • t0010-reap-logging
  • t0013-rewindable-input-false
  • t0014-rewindable-input-true
  • t0015-configurator-internals
  • t0018-write-on-close
  • t0019-max_header_len
  • t0020-at_exit-handler
  • t0022-listener_names-preload_app
  • t0100-rack-input-tests
  • t0116-client_body_buffer_size
  • t0300-no-default-middleware
  • t2000-promote-worker
  • t9000-preread-input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paarthmadan paarthmadan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paarthmadan @casperisfine