This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
[WIP] Add controller pod list in nginx configuration templating #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following annotations will be added: - enable-modsecurity - enable-owasp-core-rules - modsecurity-transaction-id Fixes kubernetes#3167
Customize ModSecurity to be used in Locations
Signed-off-by: mooncake <[email protected]>
Fix typos: reqrite -> rewrite
Update annotations.md. Remove Duplication.
Modify the wrong function name
Add e2e test for round robin load balancing
Signed-off-by: mooncake <[email protected]>
Fix some documents issues
Update nginx and e2e image
Restructure load balance e2e tests and update round robin test
Prevent X-Forwarded-Proto forward during external auth subrequest
fix logging calls
bugfix: set canary attributes when initializing balancer
… it for client_max_body_size
Convert isValidClientBodyBufferSize to something more generic
Add Snippet for ModSecurity
Set proxy_host variable to avoid using default value from proxy_pass
Revert removal of support for TCP and UDP services
Add annotation for session affinity path
Only set cookies on paths that enable session affinity
…_def bugfix: do not merge catch-all canary backends with itself
wayt
changed the title
|
Here is an example: $ k scale --replicas=3 deployment nginx-ingress-controller
deployment.extensions/nginx-ingress-controller scaled
$ http http://192.168.99.100:31362/debug "Host: http-echo.com"
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 1
Content-Type: text/html
Date: Tue, 20 Nov 2018 20:58:46 GMT
Server: nginx/1.15.6
3
$ k scale --replicas=1 deployment nginx-ingress-controller
deployment.extensions/nginx-ingress-controller scaled
$ http http://192.168.99.100:31362/debug "Host: http-echo.com"
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 1
Content-Type: text/html
Date: Tue, 20 Nov 2018 20:59:27 GMT
Server: nginx/1.15.6
1
$ k scale --replicas=5 deployment nginx-ingress-controller
deployment.extensions/nginx-ingress-controller scaled
$ http http://192.168.99.100:31362/debug "Host: http-echo.com"
HTTP/1.1 200 OK
Connection: keep-alive
Content-Length: 1
Content-Type: text/html
Date: Tue, 20 Nov 2018 21:00:26 GMT
Server: nginx/1.15.6
5 |
Increase log level when there is an invalid size value
Match buffer
Use struct to pack Ingress and its annotations
Remove initial log error during reconfiguration
wayt
commented
Nov 21, 2018
| return pods | ||
| } | ||
|
|
||
| func hasSameOwner(pod1, pod2 *corev1.Pod) bool { |
There was a problem hiding this comment.
That's the best way I've found to check if an ingress-nginx pod is under the same deployment than the running pod.
Is there any better function for that un k8s codebase?
There was a problem hiding this comment.
I can not think of any better option. One could use namespace but it would not be a complete solution since technically speaking there can be two ingress-nginx deployments under single namespace.
wayt
commented
Nov 21, 2018
| @@ -833,6 +833,10 @@ stream { | |||
|
|
|||
| {{ template "CUSTOM_ERRORS" (buildCustomErrorDeps $all.ProxySetHeaders (collectCustomErrorsPerServer $server)) }} | |||
|
|
|||
| location /debug { | |||
| return 200 "{{ len $all.ControllerPods }}"; | |||
|
Replaced by upstream PR kubernetes#3455 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This add controller pod tracking for ingress-nginx. It will feed the list of
Runningingress-nginx controller Pod to the configuration template.It is still WIP, open for comments :)
This is required for https://github.com/Shopify/edgescale/issues/631
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Cc @ElvinEfendi @Shopify/edgescale