Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotation for session affinity path #3372

Merged
merged 1 commit into from
Nov 19, 2018

Conversation

zrdaley
Copy link
Contributor

@zrdaley zrdaley commented Nov 6, 2018

What this PR does / why we need it:
This PR adds an annotation, session-cookie-path, that is used to set the path on the affinity cookie when regular expressions are used.

Which issue this PR fixes: fixes #3362

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 6, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2018
@zrdaley zrdaley changed the title [WIP] Add annotation for session affinity path Add annotation for session affinity path Nov 7, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2018
@ElvinEfendi
Copy link
Member

@zrdaley you also need to adjust internal/ingress/types_equals.go

@zrdaley zrdaley force-pushed the session-cookie-path branch 4 times, most recently from 6b6edfd to decf407 Compare November 15, 2018 14:21
@zrdaley
Copy link
Contributor Author

zrdaley commented Nov 19, 2018

@ElvinEfendi I changed Expect(len(errs)).Should(BeNumerically("==", 0)) to Expect(errs).Should(BeEmpty()) but the former is still used in a LOT of the e2e tests.

@aledbf
Copy link
Member

aledbf commented Nov 19, 2018

@ElvinEfendi I changed Expect(len(errs)).Should(BeNumerically("==", 0)) to Expect(errs).Should(BeEmpty()) but the former is still used in a LOT of the e2e tests.

@zrdaley I fixed that here a51136b

@ElvinEfendi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, zrdaley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 19, 2018
@k8s-ci-robot k8s-ci-robot merged commit 82721e5 into kubernetes:master Nov 19, 2018
@zrdaley zrdaley deleted the session-cookie-path branch November 19, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session affinity doesn't work with regular expression path
4 participants