Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade docs/preview to Vite and TW4 #2240

Merged
merged 11 commits into from
Jul 4, 2024
Merged

Conversation

frandiox
Copy link
Contributor

@frandiox frandiox commented Jun 13, 2024

Start using Vite in our docs/preview utility and upgrade to Tailwind v4 alpha which uses a Vite plugin. Otherwise we'll have deps incompatibilities with the incoming --styling tailwind feature.

Edit: we might need #2190 merged to be sure test/typecheck passes in this PR.

@frandiox frandiox requested review from blittle and a team June 13, 2024 05:39
Copy link
Contributor

We detected some changes in packages/*/package.json or packages/*/src, and there are no updates in the .changeset.
If the changes are user-facing and should cause a version bump, run npm run changeset add to track your changes and include them in the next release CHANGELOG.
If you are making simple updates to examples or documentation, you do not need to add a changeset.

Copy link
Contributor

shopify bot commented Jun 13, 2024

Oxygen deployed a preview of your fd-docs-preview-vite-tw4 branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 3:17 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 3:18 AM
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 3:17 AM
classic-remix ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 3:17 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 3:17 AM
optimistic-cart-ui ✅ Successful (Logs) Preview deployment Inspect deployment July 4, 2024 3:17 AM

Learn more about Hydrogen's GitHub integration.

@frandiox frandiox removed the request for review from blittle June 14, 2024 02:50
Copy link
Contributor

@blittle blittle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good. Thx for doing this.

@michenly michenly force-pushed the fd-docs-preview-vite-tw4 branch 2 times, most recently from 6d61c96 to e78c651 Compare July 3, 2024 21:09
@frandiox frandiox merged commit b3026d0 into main Jul 4, 2024
13 checks passed
@frandiox frandiox deleted the fd-docs-preview-vite-tw4 branch July 4, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants