Upgrade subscription example to use --diff #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
michenly
force-pushed
the
mc-subscriptions-example-to-diff
branch
3 times, most recently
from
b2283e0 to
75cc79a
Compare
michenly
force-pushed
the
mc-subscriptions-example-to-diff
branch
2 times, most recently
from
254eb23 to
fe6249b
Compare
michenly
force-pushed
the
mc-subscriptions-example-to-diff
branch
4 times, most recently
from
89e17d0 to
ade9afa
Compare
|
@juanpprieto please give this a 🎩 and make sure everything still work |
michenly
force-pushed
the
mc-subscriptions-example-to-diff
branch
from
ade9afa to
790cdd5
Compare
frandiox
reviewed
Jun 12, 2024
|
@frandiox CSS updated. Luckily while I was testing this, I found out the subscription app we were using is deprecated. Ended up updating the hydrogen-preview shop so our example is complete agagin. |
michenly
force-pushed
the
mc-subscriptions-example-to-diff
branch
from
27cf5a2 to
cc6ec6b
Compare
michenly
commented
Jun 12, 2024
| @@ -27,6 +27,7 @@ | |||
| "@types/react-dom": "^18.2.7", | |||
| "@types/react-syntax-highlighter": "^15.5.7", | |||
| "eslint": "^8.38.0", | |||
| "tailwindcss": "^3.3.0", | |||
There was a problem hiding this comment.
@frandiox should this be updated to tailwindcss v4?
There was a problem hiding this comment.
Ohh, it was missing the dependency...
I'll update it in another PR where I'm already using TW v4 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Shopify/hydrogen-internal/issues/109