Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't try to autocorrect linters that don't support autocorrect #264

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Don't try to autocorrect linters that don't support autocorrect #264

merged 1 commit into from
Jul 27, 2022

Conversation

etiennebarrie
Copy link
Member

Fix #263

@etiennebarrie etiennebarrie mentioned this pull request Jul 27, 2022
Closed
jeremycole
jeremycole approved these changes Jul 27, 2022
View reviewed changes
Copy link

@jeremycole jeremycole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's basically what I was going to propose as a fix and was testing yesterday.

@rafaelfranca rafaelfranca merged commit 326f373 into main Jul 27, 2022
@rafaelfranca rafaelfranca deleted the fix-autocorrect-not-autocorrectable branch July 27, 2022 20:30
@shopify-shipit shopify-shipit bot temporarily deployed to production August 18, 2022 22:15 Inactive
@rafaelfranca rafaelfranca mentioned this pull request Sep 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremycole jeremycole jeremycole approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autocorrect fails with exception: undefined method `autocorrect' for #<ERBLint::Linters::ErbSafety
3 participants
@etiennebarrie @jeremycole @rafaelfranca