Merge pull request #264 from Shopify/fix-autocorrect-not-autocorrectable

Don't try to autocorrect linters that don't support autocorrect
Shopify · Jul 27, 2022 · 326f373 · 326f373
2 parents f4c7558 + dc1bd1c
commit 326f373
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/erb_lint/corrector.rb b/lib/erb_lint/corrector.rb
@@ -12,7 +12,7 @@ def initialize(processed_source, offenses)
 
     def corrections
       @corrections ||= @offenses.map do |offense|
-        offense.linter.autocorrect(@processed_source, offense)
+        offense.linter.autocorrect(@processed_source, offense) if offense.linter.class.support_autocorrect?
       end.compact
     end
 

diff --git a/spec/erb_lint/cli_spec.rb b/spec/erb_lint/cli_spec.rb
@@ -514,9 +514,9 @@ def run(processed_source)
           end
 
           context "when autocorrecting an error" do
-            # We assume that linter_without_errors is not autocorrectable...
+            # We assume that linter_with_errors is not autocorrectable...
             let(:args) do
-              ["--enable-linter", "final_newline,linter_without_errors", "--stdin", linted_file, "--autocorrect"]
+              ["--enable-linter", "final_newline,linter_with_errors", "--stdin", linted_file, "--autocorrect"]
             end
 
             it "tells the user it is autocorrecting" do