-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for various countries data #18
base: master
Are you sure you want to change the base?
Conversation
Prakriti-nith
commented
Aug 7, 2018
39db236
to
e48b4e5
Compare
Should be reviewed after this PR gets merged. |
@Shekharrajak ping! |
<div class="panel-heading">Code to import data from API into <code>Daru::DataFrame</code> (yes, that's all!):</div> | ||
<div class="panel-body"> | ||
<%= | ||
rouge(%{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better if we put these lines of code (in string) and use it in view (in all the places), isn't it ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any update on this ?
], | ||
Desc: [ | ||
'Shows import from JSON API, charts, tables, and export', | ||
'Shows import from JSON API, charts, tables, and export', | ||
'Shows import from HTML pages, charts and tables' | ||
'Shows import from HTML pages, charts and tables', | ||
'Shows import from JSON API, multiple charts using PlotList, tables with formatters and CSS styling in HighCharts' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line length < 79
], | ||
Link: [ | ||
view_context.link_to('sciruby/repos', {action: 'repos', controller: 'sciruby_github'}, target: '_blank'), | ||
view_context.link_to('sciruby/watchers', {action: 'watchers', controller: 'sciruby_github'}, target: '_blank'), | ||
view_context.link_to('election/data', {action: 'data', controller: 'election'}, target: '_blank'), | ||
view_context.link_to('countries', {action: 'data_countries', controller: 'countries'}, target: '_blank'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line length < 79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything else you want to add in this PR @Prakriti-nith ?