Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move chart_class, modules and css to third parameter in HighCharts #120

Merged

Conversation

Prakriti-nith
Copy link
Contributor

Shifted chart_class, modules and css to the third parameter and updated all the IRuby examples accordingly.
Need to update the examples in demo_daru-view and wiki.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 674

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.132%

Totals Coverage Status
Change from base Build 670: 0.002%
Covered Lines: 3204
Relevant Lines: 3265

💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 8, 2018

Pull Request Test Coverage Report for Build 675

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 98.132%

Totals Coverage Status
Change from base Build 670: 0.002%
Covered Lines: 3204
Relevant Lines: 3265

💛 - Coveralls

@Prakriti-nith
Copy link
Contributor Author

@Shekharrajak can you please review this PR?

Copy link
Member

@Shekharrajak Shekharrajak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you have updated all the examples, if not then update all the examples in IRUby notebook and other web apps . Also update the wiki and refer this PR there and let me know in this PR comment.

@Shekharrajak Shekharrajak merged commit 92263f4 into SciRuby:master Aug 15, 2018
@Prakriti-nith
Copy link
Contributor Author

Yes, I have updated all the IRuby examples and also checked all of them again in this PR. I have updated the examples of Highcharts in demo_daru-view in this PR and have also added the updated CSS example in daru_examples_io_view_rails in this PR.
Updated the wiki images and examples link in Highcharts' features page and Progress Report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants