Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[People Picker] change titleText to non-required property #184

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

tsekityam
Copy link
Contributor

Q A
Bug fix? [ ]
New feature? [ ]
New sample? [ ]
Related issues? fixes #175

What's in this Pull Request?

Change titleText to non-required property, and hide the label if titleText is not provide.

@codecov-io
Copy link

Codecov Report

Merging #184 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #184   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          10       10           
  Lines         346      346           
  Branches       71       78    +7     
=======================================
  Hits          279      279           
  Misses         44       44           
  Partials       23       23
Impacted Files Coverage Δ
src/loc/en-us.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a903091...28346f4. Read the comment docs.

@estruyf estruyf merged commit 28346f4 into pnp:dev Dec 7, 2018
@estruyf
Copy link
Member

estruyf commented Dec 7, 2018

Thank you @tsekityam for this change, your change is now merged and will be available in version 1.11.0.

@tsekityam tsekityam deleted the patch-4 branch December 10, 2018 09:46
@estruyf estruyf mentioned this pull request Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants